Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use workspace resolution for example #727

Closed
wants to merge 2 commits into from

Conversation

natebosch
Copy link
Member

Use non-workspace resolution because build_runner does not support
packages where the pubspec.lock file is not at the package root.

See dart-lang/build#3721

Use non-workspace resolution because `build_runner` does not support
packages where the `pubspec.lock` file is not at the package root.

See dart-lang/build#3721
@natebosch natebosch requested a review from jakemac53 October 9, 2024 00:53
@natebosch
Copy link
Member Author

Why does this work on CI when it validated the build https://github.com/dart-lang/source_gen/actions/runs/11246229813/job/31267721145?pr=725

But it doesn't work for me locally....

@jakemac53
Copy link
Contributor

@natebosch do you have any .packages files hanging around? This can cause things to get super weird and I wonder if its related.

@natebosch
Copy link
Member Author

do you have any .packages files hanging around?

Yes, this was exactly the issue.

@natebosch natebosch closed this Oct 9, 2024
@natebosch natebosch deleted the example-without-woarkspace branch October 9, 2024 15:01
@jakemac53
Copy link
Contributor

Fwiw I filed dart-lang/tools#1546 which is the root cause here. cc @lrhn we should discuss making this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants