Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PackageGraph._tagReexportsFor and document #3772

Merged
merged 1 commit into from
May 16, 2024

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented May 16, 2024

Just some cleanup, possibly a performance boost:

  • Remove lastExportedElement; unused.
  • Do not add null values to the cycle check set.
  • Track the cycle check set as a local variable, rather than a field.
  • Document several related APIs.
  • Rename from 'reexports' to 'exports'; I think this is just simpler.
  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Just some cleanup, possibly a performance boost:

* Remove `lastExportedElement`; unused.
* Do not add `null` values to the cycle check set.
* Track the cycle check set as a local variable, rather than a field.
* Document several related APIs.
* Rename from 'reexports' to 'exports'; I think this is just simpler.
@srawlins
Copy link
Member Author

@dart-lang/analyzer-team any volunteers to review?

@srawlins
Copy link
Member Author

srawlins commented May 16, 2024

flutter bot is failing for known pre-existing failure: #3773

Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎

@srawlins srawlins merged commit 476d5cc into dart-lang:main May 16, 2024
6 of 7 checks passed
@srawlins srawlins deleted the tidy-tag-reexports branch May 16, 2024 20:25
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request May 16, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/09cba7f..77a25d7):
  77a25d7  2024-05-15  Sarah Zakarias  Add `topics` to `pubspec.yaml` (dart-archive/async#274)

dartdoc (https://github.com/dart-lang/dartdoc/compare/2e706be..476d5cc):
  476d5cc8  2024-05-16  Sam Rawlins  Refactor PackageGraph._tagReexportsFor and document (dart-lang/dartdoc#3772)
  24658cca  2024-05-14  Sam Rawlins  Privatize CommentReferenceParser._codeRef (dart-lang/dartdoc#3771)
  dff86ed9  2024-05-14  Sam Rawlins  Bump to 8.0.9 (dart-lang/dartdoc#3770)

http (https://github.com/dart-lang/http/compare/4722e03..76deb75):
  76deb75  2024-05-16  Hossein Yousefi  [cronet_http] Upgrade jni to 0.9.2 and publish 1.2.1 (dart-lang/http#1198)
  ec55561  2024-05-15  Brian Quinlan  [cronet] Use the same host and Android emulator architecture. (dart-lang/http#1201)

lints (https://github.com/dart-lang/lints/compare/f0205c1..b254c7e):
  b254c7e  2024-05-16  Devon Carew  Update README.md (dart-lang/lints#189)
  5fef508  2024-05-13  Lasse R.H. Nielsen  Tighten up the `gen_docs.dart` script. (dart-lang/lints#187)

test (https://github.com/dart-lang/test/compare/84d2a2b..2464ad5):
  2464ad5c  2024-05-16  Sarah Zakarias  Add `topics` to  package "test" `pubspec.yaml` (dart-lang/test#2230)
  6540a360  2024-05-15  dependabot[bot]  Bump the github-actions group across 1 directory with 3 updates (dart-lang/test#2229)
  4b6f029c  2024-05-15  dependabot[bot]  Bump dart_flutter_team_lints from 2.1.1 to ^3.0.0 in all packages (dart-lang/test#2228)

webdev (https://github.com/dart-lang/webdev/compare/d46cf50..fc32eb6):
  fc32eb69  2024-05-14  Elliott Brooks  Collect log message count and log at the end (dart-lang/webdev#2430)
  99abc535  2024-05-14  Elliott Brooks  Wait for a `resume` event to run the `main()` method after a page refresh (dart-lang/webdev#2431)

Change-Id: Iee28bacfc028c92e4b59d95f0c7e61f8282d2968
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366980
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants