-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cronet_http] Upgrade jni to 0.9.2 and publish 1.2.1 #1198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests timed-out so I restarted them. I have one more Dart 3.4-releated change to land and then I will publish this.
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
The emulator isn't even starting before the tests time out. Hopefully this is a temporary github glitch. |
I encountered the error described in dart-lang/native#1119 when I upgraded AGP to v8.4.0. It works fine with AGP v8.3.2. |
but the upgrade to |
Not on the app level. My android.defaultConfig.minSdkVersion 24 still fails with the same error. It has most likely something to do with the jni plugin. |
I think that the CI is broken. Working on fixing it. |
I meant after the fix to jni. You can override the jni dependency to use 0.9.2 and try. |
Thanks! Merge this whenever you see fit then. |
You mean just use this PR instead of |
Yeah, you can do that too, Here's the dependency! cronet_http:
git:
url: https://github.com/dart-lang/http
ref: jni-0.9.2
path: pkgs/cronet_http |
Yep, compiles ok using
Running OK on Android 14 (Pixel 6) with this config dependency_overrides:
cronet_http:
git:
url: https://github.com/dart-lang/http.git
ref: jni-0.9.2
path: pkgs/cronet_http and dependencies {
implementation(platform("org.jetbrains.kotlin:kotlin-bom:1.9.24"))
} (I'm not 100% sure this is still needed.) It only complains about
So I guess you're good to go 🚀 |
Yeah, that's not a problem. Although, I thought I have silenced this warning here: https://github.com/dart-lang/native/blob/main/pkgs/jni/android/src/main/java/com/github/dart_lang/jni/JniPlugin.java#L22 🤔 |
Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/09cba7f..77a25d7): 77a25d7 2024-05-15 Sarah Zakarias Add `topics` to `pubspec.yaml` (dart-archive/async#274) dartdoc (https://github.com/dart-lang/dartdoc/compare/2e706be..476d5cc): 476d5cc8 2024-05-16 Sam Rawlins Refactor PackageGraph._tagReexportsFor and document (dart-lang/dartdoc#3772) 24658cca 2024-05-14 Sam Rawlins Privatize CommentReferenceParser._codeRef (dart-lang/dartdoc#3771) dff86ed9 2024-05-14 Sam Rawlins Bump to 8.0.9 (dart-lang/dartdoc#3770) http (https://github.com/dart-lang/http/compare/4722e03..76deb75): 76deb75 2024-05-16 Hossein Yousefi [cronet_http] Upgrade jni to 0.9.2 and publish 1.2.1 (dart-lang/http#1198) ec55561 2024-05-15 Brian Quinlan [cronet] Use the same host and Android emulator architecture. (dart-lang/http#1201) lints (https://github.com/dart-lang/lints/compare/f0205c1..b254c7e): b254c7e 2024-05-16 Devon Carew Update README.md (dart-lang/lints#189) 5fef508 2024-05-13 Lasse R.H. Nielsen Tighten up the `gen_docs.dart` script. (dart-lang/lints#187) test (https://github.com/dart-lang/test/compare/84d2a2b..2464ad5): 2464ad5c 2024-05-16 Sarah Zakarias Add `topics` to package "test" `pubspec.yaml` (dart-lang/test#2230) 6540a360 2024-05-15 dependabot[bot] Bump the github-actions group across 1 directory with 3 updates (dart-lang/test#2229) 4b6f029c 2024-05-15 dependabot[bot] Bump dart_flutter_team_lints from 2.1.1 to ^3.0.0 in all packages (dart-lang/test#2228) webdev (https://github.com/dart-lang/webdev/compare/d46cf50..fc32eb6): fc32eb69 2024-05-14 Elliott Brooks Collect log message count and log at the end (dart-lang/webdev#2430) 99abc535 2024-05-14 Elliott Brooks Wait for a `resume` event to run the `main()` method after a page refresh (dart-lang/webdev#2431) Change-Id: Iee28bacfc028c92e4b59d95f0c7e61f8282d2968 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366980 Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Fix our users' issue described here: dart-lang/native#1119.
@brianquinlan Please manually publish as cronet currently needs Flutter and it won't work with the autopublish CI.