Add timeout to setTelemetry (#205)

dart-lang · Nov 20, 2023 · 938586b · 938586b
1 parent 4649307
commit 938586b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/pkgs/unified_analytics/CHANGELOG.md b/pkgs/unified_analytics/CHANGELOG.md
@@ -1,6 +1,7 @@
 ## 5.5.0-wip
 
 - Edit to the `Event.flutterCommandResult` constructor to add `commandHasTerminal`
+- Added timeout for `Analytics.setTelemetry` to prevent the clients from hanging
 
 ## 5.4.0
 

diff --git a/pkgs/unified_analytics/lib/src/analytics.dart b/pkgs/unified_analytics/lib/src/analytics.dart
@@ -647,8 +647,12 @@ class AnalyticsImpl implements Analytics {
       _clientId = _clientIdFile.readAsStringSync();
     }
 
-    // Pass to the google analytics client to send
-    return _gaClient.sendData(body);
+    // Pass to the google analytics client to send with a
+    // timeout incase http clients hang
+    return _gaClient.sendData(body).timeout(
+          const Duration(milliseconds: kDelayDuration),
+          onTimeout: () => Response('', 200),
+        );
   }
 
   @override