Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to setTelemetry #205

Conversation

eliasyishak
Copy link
Contributor

Closes issue:

Related to the flutter/flutter issue here:

This adds a timeout to the setTelemetry method, previously it was just one event being sent so we did not add any timeouts, but if the one request we send with each opt out/in event hangs, then we should cancel it.

This does not change the underlying opt out/in functionality, it will only drop the event from being sent if the request takes too long


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@eliasyishak eliasyishak merged commit 938586b into dart-lang:main Nov 20, 2023
6 checks passed
@eliasyishak eliasyishak deleted the 203-use-internal-futures-list-for-settelemetry branch November 20, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants