Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to setTelemetry #205

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Add timeout to setTelemetry #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/unified_analytics/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## 5.5.0-wip

- Edit to the `Event.flutterCommandResult` constructor to add `commandHasTerminal`
- Added timeout for `Analytics.setTelemetry` to prevent the clients from hanging

## 5.4.0

Expand Down
8 changes: 6 additions & 2 deletions pkgs/unified_analytics/lib/src/analytics.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,8 +647,12 @@ class AnalyticsImpl implements Analytics {
_clientId = _clientIdFile.readAsStringSync();
}

// Pass to the google analytics client to send
return _gaClient.sendData(body);
// Pass to the google analytics client to send with a
// timeout incase http clients hang
return _gaClient.sendData(body).timeout(
const Duration(milliseconds: kDelayDuration),
onTimeout: () => Response('', 200),
);
}

@override
Expand Down