feat: serialize on the stack #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 10, 2023
knst
requested changes
May 16, 2023
|
'This PR has been flagged as stale due to no activity for over 60 |
PastaPastaPasta
force-pushed
the
feat/serialize-stack
branch
from
8a2086e to
2efa4f2
Compare
PastaPastaPasta
force-pushed
the
feat/serialize-stack
branch
from
2efa4f2 to
0f3705b
Compare
UdjinM6
reviewed
Dec 4, 2024
|
All done |
UdjinM6
approved these changes
Dec 4, 2024
knst
reviewed
Dec 5, 2024
| std::array<uint8_t, PrivateKey::PRIVATE_KEY_SIZE> PrivateKey::SerializeToArray(bool fLegacy) const | ||
| { | ||
| std::array<uint8_t, PRIVATE_KEY_SIZE> data{}; | ||
| Serialize(data.data()); |
There was a problem hiding this comment.
Not sure, but I'm guessing no? both PrivateKey::Serialize(uint8_t *buffer) and PrivateKey::Serialize(const bool fLegacy) don't use it. Maybe. private keys are not affected by legacy / non legacy
There was a problem hiding this comment.
Yes, it's a dummy one here which is needed because our CBLSWrapper expects it to be that way for every ImplType.
knst
approved these changes
Dec 5, 2024
kwvg
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
ACK 30aa085
Tested on develop (1e553102) by updating subtree, unit and functional tests passed (see branch test_bls_75).
UdjinM6
approved these changes
Dec 5, 2024
Merged
5 tasks
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Dec 17, 2024
…bb5c5b0 as efd5c56 3bbe16c build: stop tracking cmake dependency relic_conf.h.in (Kittywhiskers Van Gogh) efd5c56 Squashed 'src/dashbls/' changes from 7e747e8a07..0bb5c5b032 (Kittywhiskers Van Gogh) 257fd5e revert: stop tracking cmake dependency relic_conf.h.in (Kittywhiskers Van Gogh) Pull request description: ## Additional Information * Dependency for #6493 * Expected subtree hash `7bec74f04710e6031590283cf405e3f141bc63310cafe5e70aae9b8d4c98cbef` (see [instructions](#6323 (review)) to calculate) * Includes [bls-signatures#75](dashpay/bls-signatures#75) and [bls-signatures#106](dashpay/bls-signatures#106) ## Breaking Changes None expected. ## Checklist: - [x] I have performed a self-review of my own code **(note: N/A)** - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)** - [x] I have made corresponding changes to the documentation **(note: N/A)** - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK 3bbe16c UdjinM6: subtree looks good, utACK 3bbe16c Tree-SHA512: 3f6853f90dfe5e3040189742858b6728e4ab505513202216f1e2f7213569798d2f2e346d73ece7505f87dc2439fde4c3a51472461163fc7c21734a734cbc0bdb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #74 to enhance library performance when integrated into other stuff