-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reading dirty memory from Util::HasOnlyZeros in G2Element deserialization #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but why some CI fail?
@ogabrielides , seems as CI is broken for awhile, previous PRs fails same: I haven't check why yet, but it seems as all of them is Go's related. |
@ogabrielides here's PR from Konstantin to fix CI failure. #82 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK (preferably after #82 + rebase)
It fixes this bug while running with valgrind: