Home screen scrolling by pulling Transaction history header #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow scrolling the app header when pulling history header
Replaced Loader with LiveData
3 tasks
# Conflicts: # wallet/src/de/schildbach/wallet/ui/TransactionsAdapter.java # wallet/src/de/schildbach/wallet/ui/WalletTransactionsFragment.java Fixed bugs and implemented missing stuff
Comment on lines
-223
to
-229
|
|
||
| val contactsFragment = ContactsFragment.newInstance(mode) | ||
| if (mode == MODE_VIEW_REQUESTS) { | ||
| addFragment(contactsFragment) | ||
| } else { | ||
| replaceFragment(contactsFragment) | ||
| } |
There was a problem hiding this comment.
Clicking "view all requests" on the Contacts screen results in a "Contact Request" screen with no entries even when there are contact requests are visible on the Contacts Screen. Not sure if this is related to this code.
There was a problem hiding this comment.
This issue is present in the current evonet-develop branch
HashEngineering
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
NMA-625
Related PR's and Dependencies
Screenshots / Videos
Before:
After
How Has This Been Tested?
Checklist: