NMA-603 | (Contacts in) Transaction History | Home Screen #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasz-ludek
reviewed
Oct 9, 2020
| public void onLoaderReset(final Loader<List<Transaction>> loader) { | ||
| // don't clear the adapter, because it will confuse users | ||
| } | ||
| //TODO: Do we need to handle this? |
There was a problem hiding this comment.
Most of the below code should be handled by LiveData/ViewModel, however walletChangeReceiver part can be ignored since we do not use ACTION_WALLET_REFERENCE_CHANGED anymore (it is a legacy code).
There was a problem hiding this comment.
As agreed with @tomasz-ludek , throttling will be implemented in #526.
tomasz-ludek
reviewed
Oct 9, 2020
| } | ||
| } | ||
|
|
||
| fun load(wallet: Wallet = WalletApplication.getInstance().wallet) { |
There was a problem hiding this comment.
the wallet val should be moved inside the method body
There was a problem hiding this comment.
Fixed in 55f7a80
tomasz-ludek
reviewed
Oct 9, 2020
HashEngineering
changed the title
HashEngineering
changed the title
HashEngineering
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: