feat!: Block Reward Reallocation (Doubling Treasury) #5588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogabrielides
added
RPC
ogabrielides
removed
the
Needs Release Notes
ogabrielides
force-pushed
the
doubling_treasury
branch
from
e550b3a to
0e537f9
Compare
UdjinM6
requested changes
Sep 29, 2023
Co-Authored-By: UdjinM6 <UdjinM6@users.noreply.github.com>
thephez
reviewed
Oct 2, 2023
knst
reviewed
Oct 2, 2023
PastaPastaPasta
approved these changes
Oct 3, 2023
This was referenced Oct 6, 2023
PastaPastaPasta
pushed a commit
that referenced
this pull request
Oct 9, 2023
## Issue being fixed or feature implemented Since `mn_rr` is already active on Testnet, because of #5588, syncing from develop is broken. ## What was done? Temporary disabled changes of #5588 for Testnet. This should be dropped when Testnet will be re-organised for Platform. ## How Has This Been Tested? Syncing Testnet ## Breaking Changes ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
PastaPastaPasta
pushed a commit
that referenced
this pull request
Oct 11, 2023
#5603) ## Issue being fixed or feature implemented Fixed a problem forgotten in #5588 in feature_asset_locks.py. ## What was done? Avoid floating operations when calculating `coinbasevalue` ## How Has This Been Tested? ## Breaking Changes ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ --------- Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
5 tasks
PastaPastaPasta
pushed a commit
that referenced
this pull request
Oct 23, 2023
## Issue being fixed or feature implemented Implementation of accepted proposal: https://www.dashcentral.org/p/expedite-60-20-20-reallocation ## What was done? Activates changers brought in #5588 on `v20` hard fork instead of `mn_rr`. ## How Has This Been Tested? run tests ## Breaking Changes Again, Testnet sync is broken ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ --------- Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Implementation of accepted proposal: https://www.dashcentral.org/p/TREASURY-REALLOCATION-60-20-20
What was done?
Once Masternode Reward Location Reallocation activates:
MN reward share should be 75% of block reward in order to represent 60% of the block subsidy. (according to the proposal)
governancebudgetis returned fromgetgovernanceinfoRPC.How Has This Been Tested?
block_reward_reallocation_testsBreaking Changes
Checklist: