feat!: Block reward reallocation activation at v20 #5639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogabrielides
commented
Oct 23, 2023
5 tasks
|
pls see 5231097 |
ogabrielides
force-pushed
the
expedite_60_20_20_reallocation
branch
from
a46cc8d to
5383e97
Compare
|
@UdjinM6 @PastaPastaPasta Done. Please review again |
PastaPastaPasta
approved these changes
Oct 23, 2023
5 tasks
|
syncs for me; CI looks pretty happy |
UdjinM6
added a commit
that referenced
this pull request
Oct 30, 2023
…, adjust sb params on regtest, tweak tests (#5641) ## Issue being fixed or feature implemented Noticed a couple of things while I was trying to figure out if an [issue](#5627 (comment)) @knst mentioned in #5627 could actually exist: 1. `GetPaymentsLimit()` won't work correctly with historical blocks rn. We don't use it that way internally but it could be done via rpc and it should provide correct results. 2. superblock params on regtest are too small to test them properly 3. because of (2) and a huge v20 activation window (comparing to sb params) `feature_governance.py` doesn't test v20 switching states. There's also no "sb on v20 activation block" test. ~NOTE: based on #5639 atm~ ## What was done? fix it, pls see individual commits ## How Has This Been Tested? run tests ## Breaking Changes n/a ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Implementation of accepted proposal: https://www.dashcentral.org/p/expedite-60-20-20-reallocation
What was done?
Activates changers brought in #5588 on
v20hard fork instead ofmn_rr.How Has This Been Tested?
run tests
Breaking Changes
Again, Testnet sync is broken
Checklist: