Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work stealing cpu load with high numbers of tasks #6178

Closed
mrocklin opened this issue Apr 22, 2022 · 3 comments · Fixed by #6179
Closed

Work stealing cpu load with high numbers of tasks #6178

mrocklin opened this issue Apr 22, 2022 · 3 comments · Fixed by #6179

Comments

@mrocklin
Copy link
Member

I was speaking with @bnaul . He mentioned that he noticed the scheduler at 100% CPU usage when it should have been in a somewhat quiet state. He had on the order of 100,000 tasks and it was spending all of its time in work stealing, in particular the maybe_move_task function. Something there may not be O(1).

image

image (1)

@fjetter
Copy link
Member

fjetter commented Apr 22, 2022

I can't see anything that's not O(1) at first glance. We changed one thing about move_task_request recently that slows it down but is constant time. We introduced a UUID generation in there

https://github.com/dask/distributed/blame/main/distributed/stealing.py#L221-L223

Note: this is the only place where we're abusing the stimulus_id for anything functional

I opened #6179 to remove the UUID

@mrocklin
Copy link
Member Author

mrocklin commented Apr 22, 2022 via email

@gjoseph92
Copy link
Collaborator

If there's a reproducible workload, pyspy_on_scheduler could easily give a definitive answer to the question.

https://github.com/gjoseph92/scheduler-profilers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants