Ensure uniqueness of steal stimulus ID #5620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stimulus ID is used to verify worker responses to distinguish concurrently running steal requests. The windows clock in particular is not strictly monotonic which caused duplicates in this test setup.
crusaderky
approved these changes
Dec 22, 2021
distributed/tests/test_steal.py
Outdated
| async def test_steal_stimulus_id_unique(c, s, *workers): | ||
| steal = s.extensions["stealing"] | ||
| num_futs = 1_000 | ||
| from distributed import Lock |
There was a problem hiding this comment.
this should be at the top of the module
…on_duplicate_steal_ids
|
rerun tests |
1 similar comment
|
rerun tests |
jrbourbeau
reviewed
Jan 6, 2022
There was a problem hiding this comment.
Just pushed a commit to address @crusaderky's feedback -- will merge after CI finishes up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stimulus ID is used to verify worker responses to distinguish
concurrently running steal requests. The windows clock in particular is
not strictly monotonic which caused duplicates in this test setup.
For real life scenarios this race is so incredibly unlikely that I don't expect to see it in the wild.
The UUID is about three times slower but I don't think this should be a performance problem.
Might address #5494
xref #5379