Optimize valid_workers
#4329
Merged
Optimize valid_workers
#4329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
force-pushed
the
opt_valid_workers
branch
from
97512a3
to
27639d3
Compare
mrocklin
reviewed
Dec 8, 2020
distributed/scheduler.py
Outdated
|
|
||
| if not valid_workers and not ts._loose_restrictions and self.workers: | ||
| if valid_workers == set() and not ts._loose_restrictions and self.workers: |
There was a problem hiding this comment.
I'm surprised that it makes sense to create an empty set each time.
There was a problem hiding this comment.
Yeah I think you are right; we can do better. Will push a fix.
In [4]: %timeit s == set()
91.3 ns ± 0.747 ns per loop (mean ± std. dev. of 7 runs, 10000000 loops each)
In [5]: %timeit s is not None and not s
37.3 ns ± 0.373 ns per loop (mean ± std. dev. of 7 runs, 10000000 loops each)(tested with s = set())
jakirkham
force-pushed
the
opt_valid_workers
branch
from
27639d3
to
d259df2
Compare
|
+1 |
jakirkham
force-pushed
the
opt_valid_workers
branch
from
d259df2
to
868b15f
Compare
This works better if we want to type `s` as `set`. Also this is a more typical default value when initializing a variable unlike `True`.
jakirkham
force-pushed
the
opt_valid_workers
branch
from
868b15f
to
b2eaf60
Compare
|
+1 |
|
Thanks Matt! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotates
valid_workersfor Cython optimization. In particular ensure it always returns asetorNone(in case all workers are viable instead ofTrueas before). Also use unique variables when they have already been assigned or if new results may have different types than before. This makes it easier to annotate these variables and for Cython to then optimize usage thereof.