Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize valid_workers #4329

Merged
merged 6 commits into from
Dec 9, 2020
Merged

Optimize valid_workers #4329

merged 6 commits into from
Dec 9, 2020

Commits on Dec 8, 2020

  1. Drop extra blank line

    @jakirkham
    jakirkham committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    f61b978 View commit details
    Browse the repository at this point in the history

  2. Use different variables for list and set

    @jakirkham
    jakirkham committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    f841617 View commit details
    Browse the repository at this point in the history

  3. Distinguish iterated variable from result

    @jakirkham
    jakirkham committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    07cc4b2 View commit details
    Browse the repository at this point in the history

  4. Annotate intermediate variables

    @jakirkham
    jakirkham committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    655224c View commit details
    Browse the repository at this point in the history

  5. Assign s None instead of True 

    This works better if we want to type `s` as `set`. Also this is a more
typical default value when initializing a variable unlike `True`.
    @jakirkham
    jakirkham committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    94dd3c9 View commit details
    Browse the repository at this point in the history

  6. Always return set from valid_workers

    @jakirkham
    jakirkham committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    b2eaf60 View commit details
    Browse the repository at this point in the history