Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: Update isort version to 5.12.0 #7513

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jan 30, 2023

poetry version 1.5.0 broke installs of isort prior to 5.11.5 (see PyCQA/isort#2077 and PyCQA/isort#2078), so we need to upgrade.

  • Tests added / passed
  • Passes pre-commit run --all-files

poetry version 1.5.0 broke installs of isort prior to 5.11.5 (see
PyCQA/isort#2077 and PyCQA/isort#2078), so we need to upgrade.
parse_timedelta,
stringify,
tmpfile,
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this is necessary (removing the type: ignore comment) other than somehow this modification to the pre-commit configuration provoked an update to mypy.

Copy link
Member

@jrbourbeau jrbourbeau Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be necessary anymore. See #7506

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I just happened to be the first person after the latest release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're the lucky one!

We'll still want to fix the underlying issue of our pre-commit build not using the main branch of dask, but the changes here should be good

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wence-. Will merge after CI finishes

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       24 files  ±0         24 suites  ±0   10h 18m 15s ⏱️ - 27m 4s
  3 335 tests ±0    3 229 ✔️  - 1     104 💤 +1  2 ±0 
39 318 runs  ±0  37 447 ✔️  - 1  1 869 💤 +1  2 ±0 

For more details on these failures, see this check.

Results for commit 3cfde11. ± Comparison against base commit 9f2fa9b.

@jrbourbeau jrbourbeau merged commit d74f500 into dask:main Jan 30, 2023
@wence- wence- deleted the wence/fix/pre-commit-isort branch January 31, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants