Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine Performance Metrics: bokeh dashboard overhaul #7910

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Jun 14, 2023

Overhaul the implementation of the Fine Performance Metrics dashboard.

Known issues

  • The legend of the stacked graph does not lose hidden activities
  • The plot does not refresh as soon as you change a selector

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       20 files  ±    0         20 suites  ±0   11h 51m 53s ⏱️ + 24m 5s
  3 677 tests  -     2    3 566 ✔️ ±    0     106 💤  -   2  5 ±0 
35 743 runs  +163  34 058 ✔️ +247  1 680 💤  - 84  5 ±0 

For more details on these failures, see this check.

Results for commit 1d426b0. ± Comparison against base commit 74a1bcd.

This pull request removes 2 tests.
distributed.protocol.tests.test_numpy
distributed.shuffle.tests.test_rechunk

Comment on lines +3547 to +3553
try:
from bokeh.palettes import interp_palette

return list(interp_palette(Viridis11, n))
except ImportError:
# Bokeh 2.4
return [Viridis11[i % len(Viridis11)] for i in range(n)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bokeh 2.4 is broken in 2023.6.0 Fine Performance Metrics: Dashboard glitch randomly adds/removes tasks
2 participants