Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix glitches in Fine Performance Metrics stacked graph #7919

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Fix glitches in Fine Performance Metrics stacked graph #7919

merged 2 commits into from
Jun 15, 2023

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Jun 15, 2023 •
edited
Loading

Fix bugs in the stacked chart in the Fine Performance Metrics dashboard, introduced in #7910

  • ymax was miscalculated, potentially clipping off bars
  • everything would be double counted

@crusaderky crusaderky requested a review from fjetter as a code owner June 15, 2023 11:52
@crusaderky crusaderky self-assigned this Jun 15, 2023
@crusaderky crusaderky changed the title Fix glitch in Fine Performance Metrics yaxis max Fix glitches in Fine Performance Metrics stacked graph Jun 15, 2023
@crusaderky crusaderky merged commit 6c3d40b into dask:main Jun 15, 2023
@crusaderky crusaderky deleted the spans_yaxis branch June 15, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milesgranger milesgranger milesgranger approved these changes

@fjetter fjetter Awaiting requested review from fjetter fjetter is a code owner

Assignees

@crusaderky crusaderky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crusaderky @milesgranger