-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support server side session #479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngsofun
force-pushed
the
token
branch
3 times, most recently
from
August 28, 2024 11:57
324ee56
to
5b1149a
Compare
everpcpc
approved these changes
Aug 29, 2024
This was referenced Sep 3, 2024
everpcpc
reviewed
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DSN param session_token
is not supported yet?
youngsofun
changed the title
feat: use session_token by default.
feat: support server side session
Nov 6, 2024
supported now |
waiting for databendlabs/databend#16786 to merge |
youngsofun
force-pushed
the
token
branch
2 times, most recently
from
November 11, 2024 01:19
a38daf9
to
dd1de89
Compare
sundy-li
approved these changes
Nov 12, 2024
@everpcpc do you need to review again? |
everpcpc
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat:
/v1/session/login
to get session token and refresh token when init APIClient. it got 404, do not use session token in the following request4. upload_stage accept a Reader, so it can not retry, check for expired and renew before request.
/v1/session/logout
when drop APIClientsession_token=enable|disable
, disable by default now, may changed to enable by default after stablelogin=enable|disable
, enabled by default, so user can choose to disable if only one query in sessionfix:
self.auth.wrap(builder)
when retry not work as what we expect. #477refactors:
others:
allow license Unicode-3.0