Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: token and cookie session id miss match. #16786

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Nov 7, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

related feature not in use yet, so the pr is safe.
find something need improvement when working with the clients.

  1. session token use the session id generated when processing cookie and stored in context
  2. small refactor of request login and refresh

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@youngsofun youngsofun force-pushed the session branch 2 times, most recently from 7460d6e to 9be6d06 Compare November 7, 2024 11:02
@youngsofun
Copy link
Member Author

cc @sundy-li ready to review

@youngsofun youngsofun added this pull request to the merge queue Nov 8, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Nov 8, 2024
@BohuTANG BohuTANG merged commit a645b0d into databendlabs:main Nov 8, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants