Skip to content

Commit

Permalink
Remove superfluous helper (#2028)
Browse files Browse the repository at this point in the history
## Changes

There was only one helper for AWS and not the other clouds. Found this
when looking through double calls to `acc.WorkspaceTest()` (see
`TestPythonWheelTaskDeployAndRunOnInteractiveCluster`).

## Tests

n/a
  • Loading branch information
pietern authored Dec 17, 2024
1 parent 23ddee8 commit 13fa43e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 10 deletions.
6 changes: 3 additions & 3 deletions integration/bundle/clusters_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ import (
)

func TestDeployBundleWithCluster(t *testing.T) {
ctx, wt := acc.WorkspaceTest(t)

if testutil.IsAWSCloud(wt) {
if testutil.GetCloud(t) == testutil.AWS {
t.Skip("Skipping test for AWS cloud because it is not permitted to create clusters")
}

ctx, wt := acc.WorkspaceTest(t)

nodeTypeId := testutil.GetCloud(t).NodeTypeID()
uniqueId := uuid.New().String()
root := initTestTemplate(t, ctx, "clusters", map[string]any{
Expand Down
4 changes: 1 addition & 3 deletions integration/bundle/python_wheel_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,7 @@ func TestPythonWheelTaskDeployAndRunWithWrapper(t *testing.T) {
}

func TestPythonWheelTaskDeployAndRunOnInteractiveCluster(t *testing.T) {
_, wt := acc.WorkspaceTest(t)

if testutil.IsAWSCloud(wt) {
if testutil.GetCloud(t) == testutil.AWS {
t.Skip("Skipping test for AWS cloud because it is not permitted to create clusters")
}

Expand Down
4 changes: 0 additions & 4 deletions internal/testutil/cloud.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,3 @@ func GetCloud(t TestingT) Cloud {
}
return -1
}

func IsAWSCloud(t TestingT) bool {
return GetCloud(t) == AWS
}

0 comments on commit 13fa43e

Please sign in to comment.