Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous helper #2028

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Remove superfluous helper #2028

merged 1 commit into from
Dec 17, 2024

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Dec 17, 2024

Changes

There was only one helper for AWS and not the other clouds. Found this when looking through double calls to acc.WorkspaceTest() (see TestPythonWheelTaskDeployAndRunOnInteractiveCluster).

Tests

n/a

Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 2028
  • Commit SHA: 770722aaea8121afcd4045387c68f925c9b4b932

Checks will be approved automatically on success.

@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12376996429

@pietern pietern added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 13fa43e Dec 17, 2024
10 checks passed
@pietern pietern deleted the trim-helpers branch December 17, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants