Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Always write message for manual test integration #374

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

hectorcast-db
Copy link
Contributor

@hectorcast-db hectorcast-db commented Oct 31, 2024

Changes

Old script could not be run from master due to security restrictions and there is no reliable way to detect if a user as secrets.

Tests

Run as pull_request.

@hectorcast-db hectorcast-db force-pushed the hectorcast-db/permissions branch from 49e6991 to 34ef4ce Compare October 31, 2024 09:18
@hectorcast-db hectorcast-db changed the title [Internal] Fix workflow permissions [Internal] Remove workflow to write message Oct 31, 2024
@hectorcast-db hectorcast-db force-pushed the hectorcast-db/permissions branch from 34ef4ce to fb64672 Compare October 31, 2024 09:29
@hectorcast-db hectorcast-db changed the title [Internal] Remove workflow to write message WIP Oct 31, 2024
@hectorcast-db hectorcast-db force-pushed the hectorcast-db/permissions branch 2 times, most recently from 3ac5067 to a465ea8 Compare October 31, 2024 09:34
@hectorcast-db hectorcast-db force-pushed the hectorcast-db/permissions branch from a465ea8 to 4e2ad78 Compare October 31, 2024 09:40
@databricks databricks deleted a comment from github-actions bot Oct 31, 2024
@hectorcast-db hectorcast-db force-pushed the hectorcast-db/permissions branch 2 times, most recently from 57b691c to 2571dcf Compare October 31, 2024 09:42
@hectorcast-db hectorcast-db changed the title WIP [Internal] Change logic to detect secrets in workflow Oct 31, 2024
@databricks databricks deleted a comment from github-actions bot Oct 31, 2024
@hectorcast-db hectorcast-db force-pushed the hectorcast-db/permissions branch from 2571dcf to 8423564 Compare October 31, 2024 09:45
@hectorcast-db hectorcast-db force-pushed the hectorcast-db/permissions branch from 8423564 to 445564c Compare October 31, 2024 09:46
@hectorcast-db hectorcast-db force-pushed the hectorcast-db/permissions branch from 445564c to d36d478 Compare October 31, 2024 09:50
# workflow runs after this workflow. In that case, we will get a message
# request for manual test execution, which is misleading since
# the test will still run automatically.
- name: Wait for 60 seconds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we increase this time? 1 min doesn't seem to be enough.

@renaudhartert-db
Copy link
Contributor

Anything that prevents us from showing the comment to everyone and making it clear (in the comment) that it is intended for the reviewers?

@hectorcast-db hectorcast-db force-pushed the hectorcast-db/permissions branch 3 times, most recently from bd051d9 to cd11907 Compare October 31, 2024 11:13
@hectorcast-db hectorcast-db force-pushed the hectorcast-db/permissions branch from cd11907 to 5ad6ba6 Compare October 31, 2024 11:13
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/11610917454

@databricks databricks deleted a comment from github-actions bot Oct 31, 2024
outputs:
has_token: ${{ steps.set-token-status.outputs.has_token }}
steps:
- name: Check if GITHUB_TOKEN is set
- name: Check if DECO_WORKFLOW_TRIGGER_APP_ID is set
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GITHUB_TOKEN is sometimes set for external contributors but with a smaller set of permissions. It is not reliable.

Copy link
Contributor

@renaudhartert-db renaudhartert-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hectorcast-db hectorcast-db changed the title [Internal] Change logic to detect secrets in workflow [Internal] Always write message for manual test integration Oct 31, 2024
@hectorcast-db hectorcast-db added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit a239cae Oct 31, 2024
17 checks passed
@hectorcast-db hectorcast-db deleted the hectorcast-db/permissions branch October 31, 2024 11:32
renaudhartert-db added a commit that referenced this pull request Nov 4, 2024
### Internal Changes

 * Add test instructions for external contributors ([#370](#370)).
 * Always write message for manual test integration ([#374](#374)).
 * Automatically trigger integration tests on PR ([#369](#369)).
 * Move templates in the code generator ([#373](#373)).

### API Changes:

 * Added `workspaceClient.aibiDashboardEmbeddingAccessPolicy()` service and `workspaceClient.aibiDashboardEmbeddingApprovedDomains()` service.
 * Added `workspaceClient.credentials()` service.
 * Added `appDeployment` field for `com.databricks.sdk.service.apps.CreateAppDeploymentRequest`.
 * Added `app` field for `com.databricks.sdk.service.apps.CreateAppRequest`.
 * Added `app` field for `com.databricks.sdk.service.apps.UpdateAppRequest`.
 * Added `table` field for `com.databricks.sdk.service.catalog.CreateOnlineTableRequest`.
 * Added `azureAad` field for `com.databricks.sdk.service.catalog.GenerateTemporaryTableCredentialResponse`.
 * Added `fullName` field for `com.databricks.sdk.service.catalog.StorageCredentialInfo`.
 * Added `dashboard` field for `com.databricks.sdk.service.dashboards.CreateDashboardRequest`.
 * Added `schedule` field for `com.databricks.sdk.service.dashboards.CreateScheduleRequest`.
 * Added `subscription` field for `com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`.
 * Added `warehouseId` field for `com.databricks.sdk.service.dashboards.Schedule`.
 * Added `dashboard` field for `com.databricks.sdk.service.dashboards.UpdateDashboardRequest`.
 * Added `schedule` field for `com.databricks.sdk.service.dashboards.UpdateScheduleRequest`.
 * Added `only` field for `com.databricks.sdk.service.jobs.RunNow`.
 * Added `pageToken` field for `com.databricks.sdk.service.oauth2.ListServicePrincipalSecretsRequest`.
 * Added `nextPageToken` field for `com.databricks.sdk.service.oauth2.ListServicePrincipalSecretsResponse`.
 * Added `connectionName` field for `com.databricks.sdk.service.pipelines.IngestionGatewayPipelineDefinition`.
 * Added `isNoPublicIpEnabled` field for `com.databricks.sdk.service.provisioning.CreateWorkspaceRequest`.
 * Added `externalCustomerInfo` and `isNoPublicIpEnabled` fields for `com.databricks.sdk.service.provisioning.Workspace`.
 * Added `lastUsedDay` field for `com.databricks.sdk.service.settings.TokenInfo`.
 * Changed `create()` method for `workspaceClient.apps()` service with new required argument order.
 * Changed `executeMessageQuery()` method for `workspaceClient.genie()` service . New request type is `com.databricks.sdk.service.dashboards.GenieExecuteMessageQueryRequest` class.
 * Changed `executeMessageQuery()` method for `workspaceClient.genie()` service to type `executeMessageQuery()` method for `workspaceClient.genie()` service.
 * Changed `create()`, `createSchedule()`, `createSubscription()` and `updateSchedule()` methods for `workspaceClient.lakeview()` service with new required argument order.
 * Removed `workspaceClient.cleanRooms()` service.
 * Removed `deploymentId`, `mode` and `sourceCodePath` fields for `com.databricks.sdk.service.apps.CreateAppDeploymentRequest`.
 * Removed `description`, `name` and `resources` fields for `com.databricks.sdk.service.apps.CreateAppRequest`.
 * Removed `description` and `resources` fields for `com.databricks.sdk.service.apps.UpdateAppRequest`.
 * Removed `name` and `spec` fields for `com.databricks.sdk.service.catalog.CreateOnlineTableRequest`.
 * Removed `displayName`, `parentPath`, `serializedDashboard` and `warehouseId` fields for `com.databricks.sdk.service.dashboards.CreateDashboardRequest`.
 * Removed `cronSchedule`, `displayName` and `pauseStatus` fields for `com.databricks.sdk.service.dashboards.CreateScheduleRequest`.
 * Removed `subscriber` field for `com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`.
 * Removed `displayName`, `etag`, `serializedDashboard` and `warehouseId` fields for `com.databricks.sdk.service.dashboards.UpdateDashboardRequest`.
 * Removed `cronSchedule`, `displayName`, `etag` and `pauseStatus` fields for `com.databricks.sdk.service.dashboards.UpdateScheduleRequest`.
 * Removed `prevPageToken` field for `com.databricks.sdk.service.jobs.Run`.

OpenAPI SHA: b63827da33b6ad958f6991435ed04778b39f7fd3, Date: 2024-11-04
renaudhartert-db added a commit that referenced this pull request Nov 6, 2024
### New Features and Improvements

 * DatabricksConfig: Add clone() support ([#376](#376)).

### Internal Changes

 * Add test instructions for external contributors ([#370](#370)).
 * Always write message for manual test integration ([#374](#374)).
 * Automatically trigger integration tests on PR ([#369](#369)).
 * Move templates in the code generator ([#373](#373)).

### API Changes:

 * Added `workspaceClient.aibiDashboardEmbeddingAccessPolicy()` service and `workspaceClient.aibiDashboardEmbeddingApprovedDomains()` service.
 * Added `workspaceClient.credentials()` service.
 * Added `appDeployment` field for `com.databricks.sdk.service.apps.CreateAppDeploymentRequest`.
 * Added `app` field for `com.databricks.sdk.service.apps.CreateAppRequest`.
 * Added `app` field for `com.databricks.sdk.service.apps.UpdateAppRequest`.
 * Added `table` field for `com.databricks.sdk.service.catalog.CreateOnlineTableRequest`.
 * Added `azureAad` field for `com.databricks.sdk.service.catalog.GenerateTemporaryTableCredentialResponse`.
 * Added `fullName` field for `com.databricks.sdk.service.catalog.StorageCredentialInfo`.
 * Added `dashboard` field for `com.databricks.sdk.service.dashboards.CreateDashboardRequest`.
 * Added `schedule` field for `com.databricks.sdk.service.dashboards.CreateScheduleRequest`.
 * Added `subscription` field for `com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`.
 * Added `warehouseId` field for `com.databricks.sdk.service.dashboards.Schedule`.
 * Added `dashboard` field for `com.databricks.sdk.service.dashboards.UpdateDashboardRequest`.
 * Added `schedule` field for `com.databricks.sdk.service.dashboards.UpdateScheduleRequest`.
 * Added `only` field for `com.databricks.sdk.service.jobs.RunNow`.
 * Added `pageToken` field for `com.databricks.sdk.service.oauth2.ListServicePrincipalSecretsRequest`.
 * Added `nextPageToken` field for `com.databricks.sdk.service.oauth2.ListServicePrincipalSecretsResponse`.
 * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.CreatePipeline`.
 * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.EditPipeline`.
 * Added `connectionName` field for `com.databricks.sdk.service.pipelines.IngestionGatewayPipelineDefinition`.
 * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.PipelineSpec`.
 * Added `isNoPublicIpEnabled` field for `com.databricks.sdk.service.provisioning.CreateWorkspaceRequest`.
 * Added `privateAccessSettingsId` field for `com.databricks.sdk.service.provisioning.UpdateWorkspaceRequest`.
 * Added `externalCustomerInfo` and `isNoPublicIpEnabled` fields for `com.databricks.sdk.service.provisioning.Workspace`.
 * Added `lastUsedDay` field for `com.databricks.sdk.service.settings.TokenInfo`.
 * Changed `create()` method for `workspaceClient.apps()` service with new required argument order.
 * Changed `executeMessageQuery()` method for `workspaceClient.genie()` service to type `executeMessageQuery()` method for `workspaceClient.genie()` service.
 * Changed `executeMessageQuery()` method for `workspaceClient.genie()` service . New request type is `com.databricks.sdk.service.dashboards.GenieExecuteMessageQueryRequest` class.
 * Changed `create()`, `createSchedule()`, `createSubscription()` and `updateSchedule()` methods for `workspaceClient.lakeview()` service with new required argument order.
 * Removed `workspaceClient.cleanRooms()` service.
 * Removed `deploymentId`, `mode` and `sourceCodePath` fields for `com.databricks.sdk.service.apps.CreateAppDeploymentRequest`.
 * Removed `description`, `name` and `resources` fields for `com.databricks.sdk.service.apps.CreateAppRequest`.
 * Removed `description` and `resources` fields for `com.databricks.sdk.service.apps.UpdateAppRequest`.
 * Removed `name` and `spec` fields for `com.databricks.sdk.service.catalog.CreateOnlineTableRequest`.
 * Removed `displayName`, `parentPath`, `serializedDashboard` and `warehouseId` fields for `com.databricks.sdk.service.dashboards.CreateDashboardRequest`.
 * Removed `cronSchedule`, `displayName` and `pauseStatus` fields for `com.databricks.sdk.service.dashboards.CreateScheduleRequest`.
 * Removed `subscriber` field for `com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`.
 * Removed `displayName`, `etag`, `serializedDashboard` and `warehouseId` fields for `com.databricks.sdk.service.dashboards.UpdateDashboardRequest`.
 * Removed `cronSchedule`, `displayName`, `etag` and `pauseStatus` fields for `com.databricks.sdk.service.dashboards.UpdateScheduleRequest`.
 * Removed `prevPageToken` field for `com.databricks.sdk.service.jobs.Run`.

OpenAPI SHA: d15ea353ad7a0279b741428a8231b84f5eb28c94, Date: 2024-11-06
renaudhartert-db added a commit that referenced this pull request Nov 6, 2024
### New Features and Improvements

 * DatabricksConfig: Add clone() support ([#376](#376)).

### Internal Changes

 * Add test instructions for external contributors ([#370](#370)).
 * Always write message for manual test integration ([#374](#374)).
 * Automatically trigger integration tests on PR ([#369](#369)).
 * Move templates in the code generator ([#373](#373)).
 * Refresh PR template ([#381](#381)).

### API Changes:

 * Added `workspaceClient.aibiDashboardEmbeddingAccessPolicy()` service and `workspaceClient.aibiDashboardEmbeddingApprovedDomains()` service.
 * Added `workspaceClient.credentials()` service.
 * Added `appDeployment` field for `com.databricks.sdk.service.apps.CreateAppDeploymentRequest`.
 * Added `app` field for `com.databricks.sdk.service.apps.CreateAppRequest`.
 * Added `app` field for `com.databricks.sdk.service.apps.UpdateAppRequest`.
 * Added `table` field for `com.databricks.sdk.service.catalog.CreateOnlineTableRequest`.
 * Added `azureAad` field for `com.databricks.sdk.service.catalog.GenerateTemporaryTableCredentialResponse`.
 * Added `fullName` field for `com.databricks.sdk.service.catalog.StorageCredentialInfo`.
 * Added `dashboard` field for `com.databricks.sdk.service.dashboards.CreateDashboardRequest`.
 * Added `schedule` field for `com.databricks.sdk.service.dashboards.CreateScheduleRequest`.
 * Added `subscription` field for `com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`.
 * Added `warehouseId` field for `com.databricks.sdk.service.dashboards.Schedule`.
 * Added `dashboard` field for `com.databricks.sdk.service.dashboards.UpdateDashboardRequest`.
 * Added `schedule` field for `com.databricks.sdk.service.dashboards.UpdateScheduleRequest`.
 * Added `only` field for `com.databricks.sdk.service.jobs.RunNow`.
 * Added `pageToken` field for `com.databricks.sdk.service.oauth2.ListServicePrincipalSecretsRequest`.
 * Added `nextPageToken` field for `com.databricks.sdk.service.oauth2.ListServicePrincipalSecretsResponse`.
 * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.CreatePipeline`.
 * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.EditPipeline`.
 * Added `connectionName` field for `com.databricks.sdk.service.pipelines.IngestionGatewayPipelineDefinition`.
 * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.PipelineSpec`.
 * Added `isNoPublicIpEnabled` field for `com.databricks.sdk.service.provisioning.CreateWorkspaceRequest`.
 * Added `privateAccessSettingsId` field for `com.databricks.sdk.service.provisioning.UpdateWorkspaceRequest`.
 * Added `externalCustomerInfo` and `isNoPublicIpEnabled` fields for `com.databricks.sdk.service.provisioning.Workspace`.
 * Added `lastUsedDay` field for `com.databricks.sdk.service.settings.TokenInfo`.
 * Changed `create()` method for `workspaceClient.apps()` service with new required argument order.
 * Changed `executeMessageQuery()` method for `workspaceClient.genie()` service to type `executeMessageQuery()` method for `workspaceClient.genie()` service.
 * Changed `executeMessageQuery()` method for `workspaceClient.genie()` service . New request type is `com.databricks.sdk.service.dashboards.GenieExecuteMessageQueryRequest` class.
 * Changed `create()`, `createSchedule()`, `createSubscription()` and `updateSchedule()` methods for `workspaceClient.lakeview()` service with new required argument order.
 * Removed `workspaceClient.cleanRooms()` service.
 * Removed `deploymentId`, `mode` and `sourceCodePath` fields for `com.databricks.sdk.service.apps.CreateAppDeploymentRequest`.
 * Removed `description`, `name` and `resources` fields for `com.databricks.sdk.service.apps.CreateAppRequest`.
 * Removed `description` and `resources` fields for `com.databricks.sdk.service.apps.UpdateAppRequest`.
 * Removed `name` and `spec` fields for `com.databricks.sdk.service.catalog.CreateOnlineTableRequest`.
 * Removed `displayName`, `parentPath`, `serializedDashboard` and `warehouseId` fields for `com.databricks.sdk.service.dashboards.CreateDashboardRequest`.
 * Removed `cronSchedule`, `displayName` and `pauseStatus` fields for `com.databricks.sdk.service.dashboards.CreateScheduleRequest`.
 * Removed `subscriber` field for `com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`.
 * Removed `displayName`, `etag`, `serializedDashboard` and `warehouseId` fields for `com.databricks.sdk.service.dashboards.UpdateDashboardRequest`.
 * Removed `cronSchedule`, `displayName`, `etag` and `pauseStatus` fields for `com.databricks.sdk.service.dashboards.UpdateScheduleRequest`.
 * Removed `prevPageToken` field for `com.databricks.sdk.service.jobs.Run`.

OpenAPI SHA: d15ea353ad7a0279b741428a8231b84f5eb28c94, Date: 2024-11-06
renaudhartert-db added a commit that referenced this pull request Nov 7, 2024
### New Features and Improvements

 * DatabricksConfig: Add clone() support ([#376](#376)).

### Bug Fixes

 * Fix vulnerabilities in the present SDK version ([#383](#383)).

### Internal Changes

 * Add test instructions for external contributors ([#370](#370)).
 * Always write message for manual test integration ([#374](#374)).
 * Automatically trigger integration tests on PR ([#369](#369)).
 * Move templates in the code generator ([#373](#373)).
 * Refresh PR template ([#381](#381)).

### API Changes:

 * Added `workspaceClient.aibiDashboardEmbeddingAccessPolicy()` service and `workspaceClient.aibiDashboardEmbeddingApprovedDomains()` service.
 * Added `workspaceClient.credentials()` service.
 * Added `appDeployment` field for `com.databricks.sdk.service.apps.CreateAppDeploymentRequest`.
 * Added `app` field for `com.databricks.sdk.service.apps.CreateAppRequest`.
 * Added `app` field for `com.databricks.sdk.service.apps.UpdateAppRequest`.
 * Added `table` field for `com.databricks.sdk.service.catalog.CreateOnlineTableRequest`.
 * Added `azureAad` field for `com.databricks.sdk.service.catalog.GenerateTemporaryTableCredentialResponse`.
 * Added `omitUsername` field for `com.databricks.sdk.service.catalog.ListTablesRequest`.
 * Added `fullName` field for `com.databricks.sdk.service.catalog.StorageCredentialInfo`.
 * Added `dashboard` field for `com.databricks.sdk.service.dashboards.CreateDashboardRequest`.
 * Added `schedule` field for `com.databricks.sdk.service.dashboards.CreateScheduleRequest`.
 * Added `subscription` field for `com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`.
 * Added `warehouseId` field for `com.databricks.sdk.service.dashboards.Schedule`.
 * Added `dashboard` field for `com.databricks.sdk.service.dashboards.UpdateDashboardRequest`.
 * Added `schedule` field for `com.databricks.sdk.service.dashboards.UpdateScheduleRequest`.
 * Added `only` field for `com.databricks.sdk.service.jobs.RunNow`.
 * Added `pageToken` field for `com.databricks.sdk.service.oauth2.ListServicePrincipalSecretsRequest`.
 * Added `nextPageToken` field for `com.databricks.sdk.service.oauth2.ListServicePrincipalSecretsResponse`.
 * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.CreatePipeline`.
 * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.EditPipeline`.
 * Added `connectionName` field for `com.databricks.sdk.service.pipelines.IngestionGatewayPipelineDefinition`.
 * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.PipelineSpec`.
 * Added `isNoPublicIpEnabled` field for `com.databricks.sdk.service.provisioning.CreateWorkspaceRequest`.
 * Added `privateAccessSettingsId` field for `com.databricks.sdk.service.provisioning.UpdateWorkspaceRequest`.
 * Added `externalCustomerInfo` and `isNoPublicIpEnabled` fields for `com.databricks.sdk.service.provisioning.Workspace`.
 * Added `lastUsedDay` field for `com.databricks.sdk.service.settings.TokenInfo`.
 * Changed `create()` method for `workspaceClient.apps()` service with new required argument order.
 * Changed `executeMessageQuery()` method for `workspaceClient.genie()` service . New request type is `com.databricks.sdk.service.dashboards.GenieExecuteMessageQueryRequest` class.
 * Changed `executeMessageQuery()` method for `workspaceClient.genie()` service to type `executeMessageQuery()` method for `workspaceClient.genie()` service.
 * Changed `create()`, `createSchedule()`, `createSubscription()` and `updateSchedule()` methods for `workspaceClient.lakeview()` service with new required argument order.
 * Removed `workspaceClient.cleanRooms()` service.
 * Removed `deploymentId`, `mode` and `sourceCodePath` fields for `com.databricks.sdk.service.apps.CreateAppDeploymentRequest`.
 * Removed `description`, `name` and `resources` fields for `com.databricks.sdk.service.apps.CreateAppRequest`.
 * Removed `description` and `resources` fields for `com.databricks.sdk.service.apps.UpdateAppRequest`.
 * Removed `name` and `spec` fields for `com.databricks.sdk.service.catalog.CreateOnlineTableRequest`.
 * Removed `displayName`, `parentPath`, `serializedDashboard` and `warehouseId` fields for `com.databricks.sdk.service.dashboards.CreateDashboardRequest`.
 * Removed `cronSchedule`, `displayName` and `pauseStatus` fields for `com.databricks.sdk.service.dashboards.CreateScheduleRequest`.
 * Removed `subscriber` field for `com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`.
 * Removed `displayName`, `etag`, `serializedDashboard` and `warehouseId` fields for `com.databricks.sdk.service.dashboards.UpdateDashboardRequest`.
 * Removed `cronSchedule`, `displayName`, `etag` and `pauseStatus` fields for `com.databricks.sdk.service.dashboards.UpdateScheduleRequest`.
 * Removed `prevPageToken` field for `com.databricks.sdk.service.jobs.Run`.

OpenAPI SHA: d25296d2f4aa7bd6195c816fdf82e0f960f775da, Date: 2024-11-07
github-merge-queue bot pushed a commit that referenced this pull request Nov 7, 2024
### New Features and Improvements

* DatabricksConfig: Add clone() support
([#376](#376)).


### Bug Fixes

* Fix vulnerabilities in the present SDK version
([#383](#383)).


### Internal Changes

* Add test instructions for external contributors
([#370](#370)).
* Always write message for manual test integration
([#374](#374)).
* Automatically trigger integration tests on PR
([#369](#369)).
* Move templates in the code generator
([#373](#373)).
* Refresh PR template
([#381](#381)).


### API Changes:

* Added `workspaceClient.aibiDashboardEmbeddingAccessPolicy()` service
and `workspaceClient.aibiDashboardEmbeddingApprovedDomains()` service.
 * Added `workspaceClient.credentials()` service.
* Added `appDeployment` field for
`com.databricks.sdk.service.apps.CreateAppDeploymentRequest`.
* Added `app` field for
`com.databricks.sdk.service.apps.CreateAppRequest`.
* Added `app` field for
`com.databricks.sdk.service.apps.UpdateAppRequest`.
* Added `table` field for
`com.databricks.sdk.service.catalog.CreateOnlineTableRequest`.
* Added `azureAad` field for
`com.databricks.sdk.service.catalog.GenerateTemporaryTableCredentialResponse`.
* Added `omitUsername` field for
`com.databricks.sdk.service.catalog.ListTablesRequest`.
* Added `fullName` field for
`com.databricks.sdk.service.catalog.StorageCredentialInfo`.
* Added `dashboard` field for
`com.databricks.sdk.service.dashboards.CreateDashboardRequest`.
* Added `schedule` field for
`com.databricks.sdk.service.dashboards.CreateScheduleRequest`.
* Added `subscription` field for
`com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`.
* Added `warehouseId` field for
`com.databricks.sdk.service.dashboards.Schedule`.
* Added `dashboard` field for
`com.databricks.sdk.service.dashboards.UpdateDashboardRequest`.
* Added `schedule` field for
`com.databricks.sdk.service.dashboards.UpdateScheduleRequest`.
 * Added `only` field for `com.databricks.sdk.service.jobs.RunNow`.
* Added `pageToken` field for
`com.databricks.sdk.service.oauth2.ListServicePrincipalSecretsRequest`.
* Added `nextPageToken` field for
`com.databricks.sdk.service.oauth2.ListServicePrincipalSecretsResponse`.
* Added `restartWindow` field for
`com.databricks.sdk.service.pipelines.CreatePipeline`.
* Added `restartWindow` field for
`com.databricks.sdk.service.pipelines.EditPipeline`.
* Added `connectionName` field for
`com.databricks.sdk.service.pipelines.IngestionGatewayPipelineDefinition`.
* Added `restartWindow` field for
`com.databricks.sdk.service.pipelines.PipelineSpec`.
* Added `isNoPublicIpEnabled` field for
`com.databricks.sdk.service.provisioning.CreateWorkspaceRequest`.
* Added `privateAccessSettingsId` field for
`com.databricks.sdk.service.provisioning.UpdateWorkspaceRequest`.
* Added `externalCustomerInfo` and `isNoPublicIpEnabled` fields for
`com.databricks.sdk.service.provisioning.Workspace`.
* Added `lastUsedDay` field for
`com.databricks.sdk.service.settings.TokenInfo`.
* Changed `create()` method for `workspaceClient.apps()` service with
new required argument order.
* Changed `executeMessageQuery()` method for `workspaceClient.genie()`
service . New request type is
`com.databricks.sdk.service.dashboards.GenieExecuteMessageQueryRequest`
class.
* Changed `executeMessageQuery()` method for `workspaceClient.genie()`
service to type `executeMessageQuery()` method for
`workspaceClient.genie()` service.
* Changed `create()`, `createSchedule()`, `createSubscription()` and
`updateSchedule()` methods for `workspaceClient.lakeview()` service with
new required argument order.
 * Removed `workspaceClient.cleanRooms()` service.
* Removed `deploymentId`, `mode` and `sourceCodePath` fields for
`com.databricks.sdk.service.apps.CreateAppDeploymentRequest`.
* Removed `description`, `name` and `resources` fields for
`com.databricks.sdk.service.apps.CreateAppRequest`.
* Removed `description` and `resources` fields for
`com.databricks.sdk.service.apps.UpdateAppRequest`.
* Removed `name` and `spec` fields for
`com.databricks.sdk.service.catalog.CreateOnlineTableRequest`.
* Removed `displayName`, `parentPath`, `serializedDashboard` and
`warehouseId` fields for
`com.databricks.sdk.service.dashboards.CreateDashboardRequest`.
* Removed `cronSchedule`, `displayName` and `pauseStatus` fields for
`com.databricks.sdk.service.dashboards.CreateScheduleRequest`.
* Removed `subscriber` field for
`com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`.
* Removed `displayName`, `etag`, `serializedDashboard` and `warehouseId`
fields for
`com.databricks.sdk.service.dashboards.UpdateDashboardRequest`.
* Removed `cronSchedule`, `displayName`, `etag` and `pauseStatus` fields
for `com.databricks.sdk.service.dashboards.UpdateScheduleRequest`.
* Removed `prevPageToken` field for
`com.databricks.sdk.service.jobs.Run`.

OpenAPI SHA: d25296d2f4aa7bd6195c816fdf82e0f960f775da, Date: 2024-11-07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants