[Feature] DatabricksConfig: Add clone() support #376
Merged
+38
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satviksr-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
satviksr-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
satviksr-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
avijeet95
approved these changes
Nov 5, 2024
|
Test Details: go/deco-tests/11698745890 |
hectorcast-db
approved these changes
Nov 6, 2024
|
Hi @satviksr-db |
renaudhartert-db
added a commit
that referenced
this pull request
Nov 6, 2024
### New Features and Improvements * DatabricksConfig: Add clone() support ([#376](#376)). ### Internal Changes * Add test instructions for external contributors ([#370](#370)). * Always write message for manual test integration ([#374](#374)). * Automatically trigger integration tests on PR ([#369](#369)). * Move templates in the code generator ([#373](#373)). ### API Changes: * Added `workspaceClient.aibiDashboardEmbeddingAccessPolicy()` service and `workspaceClient.aibiDashboardEmbeddingApprovedDomains()` service. * Added `workspaceClient.credentials()` service. * Added `appDeployment` field for `com.databricks.sdk.service.apps.CreateAppDeploymentRequest`. * Added `app` field for `com.databricks.sdk.service.apps.CreateAppRequest`. * Added `app` field for `com.databricks.sdk.service.apps.UpdateAppRequest`. * Added `table` field for `com.databricks.sdk.service.catalog.CreateOnlineTableRequest`. * Added `azureAad` field for `com.databricks.sdk.service.catalog.GenerateTemporaryTableCredentialResponse`. * Added `fullName` field for `com.databricks.sdk.service.catalog.StorageCredentialInfo`. * Added `dashboard` field for `com.databricks.sdk.service.dashboards.CreateDashboardRequest`. * Added `schedule` field for `com.databricks.sdk.service.dashboards.CreateScheduleRequest`. * Added `subscription` field for `com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`. * Added `warehouseId` field for `com.databricks.sdk.service.dashboards.Schedule`. * Added `dashboard` field for `com.databricks.sdk.service.dashboards.UpdateDashboardRequest`. * Added `schedule` field for `com.databricks.sdk.service.dashboards.UpdateScheduleRequest`. * Added `only` field for `com.databricks.sdk.service.jobs.RunNow`. * Added `pageToken` field for `com.databricks.sdk.service.oauth2.ListServicePrincipalSecretsRequest`. * Added `nextPageToken` field for `com.databricks.sdk.service.oauth2.ListServicePrincipalSecretsResponse`. * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.CreatePipeline`. * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.EditPipeline`. * Added `connectionName` field for `com.databricks.sdk.service.pipelines.IngestionGatewayPipelineDefinition`. * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.PipelineSpec`. * Added `isNoPublicIpEnabled` field for `com.databricks.sdk.service.provisioning.CreateWorkspaceRequest`. * Added `privateAccessSettingsId` field for `com.databricks.sdk.service.provisioning.UpdateWorkspaceRequest`. * Added `externalCustomerInfo` and `isNoPublicIpEnabled` fields for `com.databricks.sdk.service.provisioning.Workspace`. * Added `lastUsedDay` field for `com.databricks.sdk.service.settings.TokenInfo`. * Changed `create()` method for `workspaceClient.apps()` service with new required argument order. * Changed `executeMessageQuery()` method for `workspaceClient.genie()` service to type `executeMessageQuery()` method for `workspaceClient.genie()` service. * Changed `executeMessageQuery()` method for `workspaceClient.genie()` service . New request type is `com.databricks.sdk.service.dashboards.GenieExecuteMessageQueryRequest` class. * Changed `create()`, `createSchedule()`, `createSubscription()` and `updateSchedule()` methods for `workspaceClient.lakeview()` service with new required argument order. * Removed `workspaceClient.cleanRooms()` service. * Removed `deploymentId`, `mode` and `sourceCodePath` fields for `com.databricks.sdk.service.apps.CreateAppDeploymentRequest`. * Removed `description`, `name` and `resources` fields for `com.databricks.sdk.service.apps.CreateAppRequest`. * Removed `description` and `resources` fields for `com.databricks.sdk.service.apps.UpdateAppRequest`. * Removed `name` and `spec` fields for `com.databricks.sdk.service.catalog.CreateOnlineTableRequest`. * Removed `displayName`, `parentPath`, `serializedDashboard` and `warehouseId` fields for `com.databricks.sdk.service.dashboards.CreateDashboardRequest`. * Removed `cronSchedule`, `displayName` and `pauseStatus` fields for `com.databricks.sdk.service.dashboards.CreateScheduleRequest`. * Removed `subscriber` field for `com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`. * Removed `displayName`, `etag`, `serializedDashboard` and `warehouseId` fields for `com.databricks.sdk.service.dashboards.UpdateDashboardRequest`. * Removed `cronSchedule`, `displayName`, `etag` and `pauseStatus` fields for `com.databricks.sdk.service.dashboards.UpdateScheduleRequest`. * Removed `prevPageToken` field for `com.databricks.sdk.service.jobs.Run`. OpenAPI SHA: d15ea353ad7a0279b741428a8231b84f5eb28c94, Date: 2024-11-06
renaudhartert-db
added a commit
that referenced
this pull request
Nov 6, 2024
### New Features and Improvements * DatabricksConfig: Add clone() support ([#376](#376)). ### Internal Changes * Add test instructions for external contributors ([#370](#370)). * Always write message for manual test integration ([#374](#374)). * Automatically trigger integration tests on PR ([#369](#369)). * Move templates in the code generator ([#373](#373)). * Refresh PR template ([#381](#381)). ### API Changes: * Added `workspaceClient.aibiDashboardEmbeddingAccessPolicy()` service and `workspaceClient.aibiDashboardEmbeddingApprovedDomains()` service. * Added `workspaceClient.credentials()` service. * Added `appDeployment` field for `com.databricks.sdk.service.apps.CreateAppDeploymentRequest`. * Added `app` field for `com.databricks.sdk.service.apps.CreateAppRequest`. * Added `app` field for `com.databricks.sdk.service.apps.UpdateAppRequest`. * Added `table` field for `com.databricks.sdk.service.catalog.CreateOnlineTableRequest`. * Added `azureAad` field for `com.databricks.sdk.service.catalog.GenerateTemporaryTableCredentialResponse`. * Added `fullName` field for `com.databricks.sdk.service.catalog.StorageCredentialInfo`. * Added `dashboard` field for `com.databricks.sdk.service.dashboards.CreateDashboardRequest`. * Added `schedule` field for `com.databricks.sdk.service.dashboards.CreateScheduleRequest`. * Added `subscription` field for `com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`. * Added `warehouseId` field for `com.databricks.sdk.service.dashboards.Schedule`. * Added `dashboard` field for `com.databricks.sdk.service.dashboards.UpdateDashboardRequest`. * Added `schedule` field for `com.databricks.sdk.service.dashboards.UpdateScheduleRequest`. * Added `only` field for `com.databricks.sdk.service.jobs.RunNow`. * Added `pageToken` field for `com.databricks.sdk.service.oauth2.ListServicePrincipalSecretsRequest`. * Added `nextPageToken` field for `com.databricks.sdk.service.oauth2.ListServicePrincipalSecretsResponse`. * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.CreatePipeline`. * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.EditPipeline`. * Added `connectionName` field for `com.databricks.sdk.service.pipelines.IngestionGatewayPipelineDefinition`. * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.PipelineSpec`. * Added `isNoPublicIpEnabled` field for `com.databricks.sdk.service.provisioning.CreateWorkspaceRequest`. * Added `privateAccessSettingsId` field for `com.databricks.sdk.service.provisioning.UpdateWorkspaceRequest`. * Added `externalCustomerInfo` and `isNoPublicIpEnabled` fields for `com.databricks.sdk.service.provisioning.Workspace`. * Added `lastUsedDay` field for `com.databricks.sdk.service.settings.TokenInfo`. * Changed `create()` method for `workspaceClient.apps()` service with new required argument order. * Changed `executeMessageQuery()` method for `workspaceClient.genie()` service to type `executeMessageQuery()` method for `workspaceClient.genie()` service. * Changed `executeMessageQuery()` method for `workspaceClient.genie()` service . New request type is `com.databricks.sdk.service.dashboards.GenieExecuteMessageQueryRequest` class. * Changed `create()`, `createSchedule()`, `createSubscription()` and `updateSchedule()` methods for `workspaceClient.lakeview()` service with new required argument order. * Removed `workspaceClient.cleanRooms()` service. * Removed `deploymentId`, `mode` and `sourceCodePath` fields for `com.databricks.sdk.service.apps.CreateAppDeploymentRequest`. * Removed `description`, `name` and `resources` fields for `com.databricks.sdk.service.apps.CreateAppRequest`. * Removed `description` and `resources` fields for `com.databricks.sdk.service.apps.UpdateAppRequest`. * Removed `name` and `spec` fields for `com.databricks.sdk.service.catalog.CreateOnlineTableRequest`. * Removed `displayName`, `parentPath`, `serializedDashboard` and `warehouseId` fields for `com.databricks.sdk.service.dashboards.CreateDashboardRequest`. * Removed `cronSchedule`, `displayName` and `pauseStatus` fields for `com.databricks.sdk.service.dashboards.CreateScheduleRequest`. * Removed `subscriber` field for `com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`. * Removed `displayName`, `etag`, `serializedDashboard` and `warehouseId` fields for `com.databricks.sdk.service.dashboards.UpdateDashboardRequest`. * Removed `cronSchedule`, `displayName`, `etag` and `pauseStatus` fields for `com.databricks.sdk.service.dashboards.UpdateScheduleRequest`. * Removed `prevPageToken` field for `com.databricks.sdk.service.jobs.Run`. OpenAPI SHA: d15ea353ad7a0279b741428a8231b84f5eb28c94, Date: 2024-11-06
renaudhartert-db
added a commit
that referenced
this pull request
Nov 7, 2024
### New Features and Improvements * DatabricksConfig: Add clone() support ([#376](#376)). ### Bug Fixes * Fix vulnerabilities in the present SDK version ([#383](#383)). ### Internal Changes * Add test instructions for external contributors ([#370](#370)). * Always write message for manual test integration ([#374](#374)). * Automatically trigger integration tests on PR ([#369](#369)). * Move templates in the code generator ([#373](#373)). * Refresh PR template ([#381](#381)). ### API Changes: * Added `workspaceClient.aibiDashboardEmbeddingAccessPolicy()` service and `workspaceClient.aibiDashboardEmbeddingApprovedDomains()` service. * Added `workspaceClient.credentials()` service. * Added `appDeployment` field for `com.databricks.sdk.service.apps.CreateAppDeploymentRequest`. * Added `app` field for `com.databricks.sdk.service.apps.CreateAppRequest`. * Added `app` field for `com.databricks.sdk.service.apps.UpdateAppRequest`. * Added `table` field for `com.databricks.sdk.service.catalog.CreateOnlineTableRequest`. * Added `azureAad` field for `com.databricks.sdk.service.catalog.GenerateTemporaryTableCredentialResponse`. * Added `omitUsername` field for `com.databricks.sdk.service.catalog.ListTablesRequest`. * Added `fullName` field for `com.databricks.sdk.service.catalog.StorageCredentialInfo`. * Added `dashboard` field for `com.databricks.sdk.service.dashboards.CreateDashboardRequest`. * Added `schedule` field for `com.databricks.sdk.service.dashboards.CreateScheduleRequest`. * Added `subscription` field for `com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`. * Added `warehouseId` field for `com.databricks.sdk.service.dashboards.Schedule`. * Added `dashboard` field for `com.databricks.sdk.service.dashboards.UpdateDashboardRequest`. * Added `schedule` field for `com.databricks.sdk.service.dashboards.UpdateScheduleRequest`. * Added `only` field for `com.databricks.sdk.service.jobs.RunNow`. * Added `pageToken` field for `com.databricks.sdk.service.oauth2.ListServicePrincipalSecretsRequest`. * Added `nextPageToken` field for `com.databricks.sdk.service.oauth2.ListServicePrincipalSecretsResponse`. * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.CreatePipeline`. * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.EditPipeline`. * Added `connectionName` field for `com.databricks.sdk.service.pipelines.IngestionGatewayPipelineDefinition`. * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.PipelineSpec`. * Added `isNoPublicIpEnabled` field for `com.databricks.sdk.service.provisioning.CreateWorkspaceRequest`. * Added `privateAccessSettingsId` field for `com.databricks.sdk.service.provisioning.UpdateWorkspaceRequest`. * Added `externalCustomerInfo` and `isNoPublicIpEnabled` fields for `com.databricks.sdk.service.provisioning.Workspace`. * Added `lastUsedDay` field for `com.databricks.sdk.service.settings.TokenInfo`. * Changed `create()` method for `workspaceClient.apps()` service with new required argument order. * Changed `executeMessageQuery()` method for `workspaceClient.genie()` service . New request type is `com.databricks.sdk.service.dashboards.GenieExecuteMessageQueryRequest` class. * Changed `executeMessageQuery()` method for `workspaceClient.genie()` service to type `executeMessageQuery()` method for `workspaceClient.genie()` service. * Changed `create()`, `createSchedule()`, `createSubscription()` and `updateSchedule()` methods for `workspaceClient.lakeview()` service with new required argument order. * Removed `workspaceClient.cleanRooms()` service. * Removed `deploymentId`, `mode` and `sourceCodePath` fields for `com.databricks.sdk.service.apps.CreateAppDeploymentRequest`. * Removed `description`, `name` and `resources` fields for `com.databricks.sdk.service.apps.CreateAppRequest`. * Removed `description` and `resources` fields for `com.databricks.sdk.service.apps.UpdateAppRequest`. * Removed `name` and `spec` fields for `com.databricks.sdk.service.catalog.CreateOnlineTableRequest`. * Removed `displayName`, `parentPath`, `serializedDashboard` and `warehouseId` fields for `com.databricks.sdk.service.dashboards.CreateDashboardRequest`. * Removed `cronSchedule`, `displayName` and `pauseStatus` fields for `com.databricks.sdk.service.dashboards.CreateScheduleRequest`. * Removed `subscriber` field for `com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`. * Removed `displayName`, `etag`, `serializedDashboard` and `warehouseId` fields for `com.databricks.sdk.service.dashboards.UpdateDashboardRequest`. * Removed `cronSchedule`, `displayName`, `etag` and `pauseStatus` fields for `com.databricks.sdk.service.dashboards.UpdateScheduleRequest`. * Removed `prevPageToken` field for `com.databricks.sdk.service.jobs.Run`. OpenAPI SHA: d25296d2f4aa7bd6195c816fdf82e0f960f775da, Date: 2024-11-07
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
### New Features and Improvements * DatabricksConfig: Add clone() support ([#376](#376)). ### Bug Fixes * Fix vulnerabilities in the present SDK version ([#383](#383)). ### Internal Changes * Add test instructions for external contributors ([#370](#370)). * Always write message for manual test integration ([#374](#374)). * Automatically trigger integration tests on PR ([#369](#369)). * Move templates in the code generator ([#373](#373)). * Refresh PR template ([#381](#381)). ### API Changes: * Added `workspaceClient.aibiDashboardEmbeddingAccessPolicy()` service and `workspaceClient.aibiDashboardEmbeddingApprovedDomains()` service. * Added `workspaceClient.credentials()` service. * Added `appDeployment` field for `com.databricks.sdk.service.apps.CreateAppDeploymentRequest`. * Added `app` field for `com.databricks.sdk.service.apps.CreateAppRequest`. * Added `app` field for `com.databricks.sdk.service.apps.UpdateAppRequest`. * Added `table` field for `com.databricks.sdk.service.catalog.CreateOnlineTableRequest`. * Added `azureAad` field for `com.databricks.sdk.service.catalog.GenerateTemporaryTableCredentialResponse`. * Added `omitUsername` field for `com.databricks.sdk.service.catalog.ListTablesRequest`. * Added `fullName` field for `com.databricks.sdk.service.catalog.StorageCredentialInfo`. * Added `dashboard` field for `com.databricks.sdk.service.dashboards.CreateDashboardRequest`. * Added `schedule` field for `com.databricks.sdk.service.dashboards.CreateScheduleRequest`. * Added `subscription` field for `com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`. * Added `warehouseId` field for `com.databricks.sdk.service.dashboards.Schedule`. * Added `dashboard` field for `com.databricks.sdk.service.dashboards.UpdateDashboardRequest`. * Added `schedule` field for `com.databricks.sdk.service.dashboards.UpdateScheduleRequest`. * Added `only` field for `com.databricks.sdk.service.jobs.RunNow`. * Added `pageToken` field for `com.databricks.sdk.service.oauth2.ListServicePrincipalSecretsRequest`. * Added `nextPageToken` field for `com.databricks.sdk.service.oauth2.ListServicePrincipalSecretsResponse`. * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.CreatePipeline`. * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.EditPipeline`. * Added `connectionName` field for `com.databricks.sdk.service.pipelines.IngestionGatewayPipelineDefinition`. * Added `restartWindow` field for `com.databricks.sdk.service.pipelines.PipelineSpec`. * Added `isNoPublicIpEnabled` field for `com.databricks.sdk.service.provisioning.CreateWorkspaceRequest`. * Added `privateAccessSettingsId` field for `com.databricks.sdk.service.provisioning.UpdateWorkspaceRequest`. * Added `externalCustomerInfo` and `isNoPublicIpEnabled` fields for `com.databricks.sdk.service.provisioning.Workspace`. * Added `lastUsedDay` field for `com.databricks.sdk.service.settings.TokenInfo`. * Changed `create()` method for `workspaceClient.apps()` service with new required argument order. * Changed `executeMessageQuery()` method for `workspaceClient.genie()` service . New request type is `com.databricks.sdk.service.dashboards.GenieExecuteMessageQueryRequest` class. * Changed `executeMessageQuery()` method for `workspaceClient.genie()` service to type `executeMessageQuery()` method for `workspaceClient.genie()` service. * Changed `create()`, `createSchedule()`, `createSubscription()` and `updateSchedule()` methods for `workspaceClient.lakeview()` service with new required argument order. * Removed `workspaceClient.cleanRooms()` service. * Removed `deploymentId`, `mode` and `sourceCodePath` fields for `com.databricks.sdk.service.apps.CreateAppDeploymentRequest`. * Removed `description`, `name` and `resources` fields for `com.databricks.sdk.service.apps.CreateAppRequest`. * Removed `description` and `resources` fields for `com.databricks.sdk.service.apps.UpdateAppRequest`. * Removed `name` and `spec` fields for `com.databricks.sdk.service.catalog.CreateOnlineTableRequest`. * Removed `displayName`, `parentPath`, `serializedDashboard` and `warehouseId` fields for `com.databricks.sdk.service.dashboards.CreateDashboardRequest`. * Removed `cronSchedule`, `displayName` and `pauseStatus` fields for `com.databricks.sdk.service.dashboards.CreateScheduleRequest`. * Removed `subscriber` field for `com.databricks.sdk.service.dashboards.CreateSubscriptionRequest`. * Removed `displayName`, `etag`, `serializedDashboard` and `warehouseId` fields for `com.databricks.sdk.service.dashboards.UpdateDashboardRequest`. * Removed `cronSchedule`, `displayName`, `etag` and `pauseStatus` fields for `com.databricks.sdk.service.dashboards.UpdateScheduleRequest`. * Removed `prevPageToken` field for `com.databricks.sdk.service.jobs.Run`. OpenAPI SHA: d25296d2f4aa7bd6195c816fdf82e0f960f775da, Date: 2024-11-07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds support for cloning DatabricksConfig(), this is needed because we need a way to set configurations per API call such as
However, we still want to use the cached oauth token etc and we would like the header factory to be a common object across workspace clients and databricks configs
Ideally this should be supported by the SDK itself natively, however since its not supported and it will take significant migration to achieve that, this is a work around to achieve the same.
Tests
Added UT