Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert incremental on_schema_change tests. #258

Closed
wants to merge 5 commits into from
Closed

Convert incremental on_schema_change tests. #258

wants to merge 5 commits into from

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Jan 20, 2023

Description

Converts incremental on_schema_change tests, following dbt-labs/dbt-spark#593.

@ueshin ueshin requested a review from andrefurlan-db January 20, 2023 00:47
andrefurlan-db
andrefurlan-db reviewed Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@andrefurlan-db andrefurlan-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a one-to-one change? Any coverage we are losing/gaining?

@ueshin
Copy link
Collaborator Author

ueshin commented Jan 27, 2023 •
edited
Loading

@andrefurlan-db Now this covers all the combinations gaining the coverage.

@ueshin ueshin closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrefurlan-db andrefurlan-db andrefurlan-db left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ueshin @andrefurlan-db