Convert incremental on_schema_change tests #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
commented
Jan 14, 2023
5 tasks
jtcohen6
force-pushed
the
jerco/convert-onschemachange-tests
branch
3 times, most recently
from
3423f16 to
af6afbc
Compare
jtcohen6
force-pushed
the
jerco/convert-onschemachange-tests
branch
from
af6afbc to
34144d7
Compare
3 tasks
ChenyuLInx
approved these changes
Jan 18, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dbt-labs/dbt-core#6618
These tests had not been updated since fall 2021. They are functionally equivalent to the converted "adapter zone" test that we can now inherit. The trickiness is the matrix of compatibility between
on_schema_changemodes and incremental strategies / file formats / connections / runtimes.Note: I have not been able to run these tests locally, so I anticipate a very high chance of failure!
Checklist
I have runchangie newto create a changelog entry