Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for account-level configuration and multi-cloud workspace list #264

Merged
merged 7 commits into from
Sep 25, 2023

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Sep 22, 2023

This PR renames MigrationConfig to WorkspaceConfig and adds AccountConfig, which persists configuration file at ~/.ucx/config.yml - same homefolder, but this time on the local machine, instead of the workspace FS.

@nfx nfx added the feat/account-level cross-workspace installations label Sep 22, 2023
@nfx nfx linked an issue Sep 22, 2023 that may be closed by this pull request
… listing

This PR renames `MigrationConfig` to `WorkspaceConfig` and adds `AccountConfig`, which persists configuration file at `~/.ucx/config.yml` - same homefolder, but this time on the local machine, instead of the workspace FS.
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #264 (1d571d6) into main (f7eab58) will decrease coverage by 0.06%.
The diff coverage is 82.65%.

@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
- Coverage   83.37%   83.31%   -0.06%     
==========================================
  Files          29       30       +1     
  Lines        1979     2122     +143     
  Branches      337      359      +22     
==========================================
+ Hits         1650     1768     +118     
- Misses        261      276      +15     
- Partials       68       78      +10     
Files Changed Coverage Δ
src/databricks/labs/ucx/install.py 80.92% <56.25%> (-1.30%) ⬇️
src/databricks/labs/ucx/framework/tasks.py 57.14% <66.66%> (ø)
src/databricks/labs/ucx/config.py 86.29% <83.60%> (+1.67%) ⬆️
src/databricks/labs/ucx/account/workspaces.py 84.00% <84.00%> (ø)
src/databricks/labs/ucx/runtime.py 56.33% <100.00%> (ø)
.../databricks/labs/ucx/workspace_access/migration.py 47.69% <100.00%> (ø)

@nfx nfx marked this pull request as ready for review September 25, 2023 12:21
@nfx nfx enabled auto-merge September 25, 2023 12:52
@nfx nfx disabled auto-merge September 25, 2023 13:07
@nfx nfx merged commit c3c2295 into main Sep 25, 2023
3 of 5 checks passed
@nfx nfx deleted the init/account-level branch September 25, 2023 13:07
FastLee pushed a commit that referenced this pull request Sep 25, 2023
… list (#264)

This PR renames `MigrationConfig` to `WorkspaceConfig` and adds
`AccountConfig`, which persists configuration file at
`~/.ucx/config.yml` - same homefolder, but this time on the local
machine, instead of the workspace FS.
nfx added a commit that referenced this pull request Sep 29, 2023
# Version changelog

## 0.2.0

* Added retrieving for all account-level groups with matching names to workspace-level groups in case no explicit configuration ([#277](#277)).
* Added crawler for Azure Service principals used for direct storage access ([#305](#305)).
* Added more SQL queries to the assessment step dashboard ([#269](#269)).
* Added filtering out for job clusters in the clusters crawler ([#298](#298)).
* Added recording errors from `crawl_tables` step in `$inventory.table_failures` table and display counter on the dashboard ([#300](#300)).
* Added comprehensive introduction user manual ([#273](#273)).
* Added interactive tutorial for local group migration readme ([#291](#291)).
* Added tutorial links to the landing page of documentation ([#290](#290)).
* Added (internal) support for account-level configuration and multi-cloud workspace list ([#264](#264)).
* Improved order of tasks in the README notebook ([#286](#286)).
* Improved installation script to run in a Windows Git Bash terminal ([#282](#282)).
* Improved installation script by setting log level to uppercase by default ([#271](#271)).
* Improved installation finish messages within installer script ([#267](#267)).
* Improved automation for `MANAGED` table migration and continued building tables migration component ([#295](#295)).
* Fixed debug notebook code with refactored package structure ([#250](#250)) ([#265](#265)).
* Fixed replacement of custom configured database to replicate in the report for external locations ([#296](#296)).
* Removed redundant `notebooks` top-level folder ([#263](#263)).
* Split checking for test failures and linting errors into independent GitHub Actions checks ([#287](#287)).
* Verify query metadata for assessment dashboards during unit tests ([#294](#294)).
@nfx nfx mentioned this pull request Sep 29, 2023
nfx added a commit that referenced this pull request Sep 29, 2023
# Version changelog

## 0.2.0

* Added retrieving for all account-level groups with matching names to
workspace-level groups in case no explicit configuration
([#277](#277)).
* Added crawler for Azure Service principals used for direct storage
access ([#305](#305)).
* Added more SQL queries to the assessment step dashboard
([#269](#269)).
* Added filtering out for job clusters in the clusters crawler
([#298](#298)).
* Added recording errors from `crawl_tables` step in
`$inventory.table_failures` table and display counter on the dashboard
([#300](#300)).
* Added comprehensive introduction user manual
([#273](#273)).
* Added interactive tutorial for local group migration readme
([#291](#291)).
* Added tutorial links to the landing page of documentation
([#290](#290)).
* Added (internal) support for account-level configuration and
multi-cloud workspace list
([#264](#264)).
* Improved order of tasks in the README notebook
([#286](#286)).
* Improved installation script to run in a Windows Git Bash terminal
([#282](#282)).
* Improved installation script by setting log level to uppercase by
default ([#271](#271)).
* Improved installation finish messages within installer script
([#267](#267)).
* Improved automation for `MANAGED` table migration and continued
building tables migration component
([#295](#295)).
* Fixed debug notebook code with refactored package structure
([#250](#250))
([#265](#265)).
* Fixed replacement of custom configured database to replicate in the
report for external locations
([#296](#296)).
* Removed redundant `notebooks` top-level folder
([#263](#263)).
* Split checking for test failures and linting errors into independent
GitHub Actions checks
([#287](#287)).
* Verify query metadata for assessment dashboards during unit tests
([#294](#294)).
FastLee pushed a commit that referenced this pull request Sep 29, 2023
# Version changelog

## 0.2.0

* Added retrieving for all account-level groups with matching names to
workspace-level groups in case no explicit configuration
([#277](#277)).
* Added crawler for Azure Service principals used for direct storage
access ([#305](#305)).
* Added more SQL queries to the assessment step dashboard
([#269](#269)).
* Added filtering out for job clusters in the clusters crawler
([#298](#298)).
* Added recording errors from `crawl_tables` step in
`$inventory.table_failures` table and display counter on the dashboard
([#300](#300)).
* Added comprehensive introduction user manual
([#273](#273)).
* Added interactive tutorial for local group migration readme
([#291](#291)).
* Added tutorial links to the landing page of documentation
([#290](#290)).
* Added (internal) support for account-level configuration and
multi-cloud workspace list
([#264](#264)).
* Improved order of tasks in the README notebook
([#286](#286)).
* Improved installation script to run in a Windows Git Bash terminal
([#282](#282)).
* Improved installation script by setting log level to uppercase by
default ([#271](#271)).
* Improved installation finish messages within installer script
([#267](#267)).
* Improved automation for `MANAGED` table migration and continued
building tables migration component
([#295](#295)).
* Fixed debug notebook code with refactored package structure
([#250](#250))
([#265](#265)).
* Fixed replacement of custom configured database to replicate in the
report for external locations
([#296](#296)).
* Removed redundant `notebooks` top-level folder
([#263](#263)).
* Split checking for test failures and linting errors into independent
GitHub Actions checks
([#287](#287)).
* Verify query metadata for assessment dashboards during unit tests
([#294](#294)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat/account-level cross-workspace installations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalize config handling to the entire toolkit
1 participant