Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep order of tasks in the README notebook #286

Merged
merged 6 commits into from
Sep 26, 2023
Merged

Keep order of tasks in the README notebook #286

merged 6 commits into from
Sep 26, 2023

Conversation

larsgeorge-db
Copy link
Contributor

@larsgeorge-db larsgeorge-db commented Sep 23, 2023 •
edited
Loading

Resolves #285

@larsgeorge-db
Copy link
Contributor Author

Works

image

@codecov
Copy link

codecov bot commented Sep 23, 2023 •
edited
Loading

Codecov Report

Merging #286 (980d0f0) into main (cd033d5) will decrease coverage by 0.03%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
- Coverage   83.36%   83.34%   -0.03%     
==========================================
  Files          30       30              
  Lines        2128     2143      +15     
  Branches      361      365       +4     
==========================================
+ Hits         1774     1786      +12     
- Misses        276      278       +2     
- Partials       78       79       +1
Files Coverage Δ
src/databricks/labs/ucx/framework/tasks.py 57.89% <100.00%> (+0.75%) ⬆️
src/databricks/labs/ucx/install.py 80.82% <81.25%> (-0.10%) ⬇️

nfx
nfx requested changes Sep 23, 2023
View reviewed changes
src/databricks/labs/ucx/framework/tasks.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/install.py Show resolved Hide resolved
tests/unit/test_install.py Outdated Show resolved Hide resolved
@nfx
Copy link
Contributor

nfx commented Sep 23, 2023

Also change the PR title to be changelog-friendly

@larsgeorge-db larsgeorge-db changed the title Keep order of tasks in the README notebook (#285) Keep order of tasks in the README notebook Sep 25, 2023
nfx
nfx requested changes Sep 26, 2023
View reviewed changes
src/databricks/labs/ucx/install.py Outdated Show resolved Hide resolved
src/databricks/labs/ucx/install.py Outdated Show resolved Hide resolved
nfx
nfx approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for implementation, but fix the tests

@nfx nfx enabled auto-merge September 26, 2023 12:15
@nfx nfx added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit b1cd014 Sep 26, 2023
3 of 5 checks passed
@nfx nfx deleted the feature/issue_285_retain_order branch September 26, 2023 23:02
nfx added a commit that referenced this pull request Sep 29, 2023
@nfx
Release v0.2.0
f885a0d 
# Version changelog

## 0.2.0

* Added retrieving for all account-level groups with matching names to workspace-level groups in case no explicit configuration ([#277](#277)).
* Added crawler for Azure Service principals used for direct storage access ([#305](#305)).
* Added more SQL queries to the assessment step dashboard ([#269](#269)).
* Added filtering out for job clusters in the clusters crawler ([#298](#298)).
* Added recording errors from `crawl_tables` step in `$inventory.table_failures` table and display counter on the dashboard ([#300](#300)).
* Added comprehensive introduction user manual ([#273](#273)).
* Added interactive tutorial for local group migration readme ([#291](#291)).
* Added tutorial links to the landing page of documentation ([#290](#290)).
* Added (internal) support for account-level configuration and multi-cloud workspace list ([#264](#264)).
* Improved order of tasks in the README notebook ([#286](#286)).
* Improved installation script to run in a Windows Git Bash terminal ([#282](#282)).
* Improved installation script by setting log level to uppercase by default ([#271](#271)).
* Improved installation finish messages within installer script ([#267](#267)).
* Improved automation for `MANAGED` table migration and continued building tables migration component ([#295](#295)).
* Fixed debug notebook code with refactored package structure ([#250](#250)) ([#265](#265)).
* Fixed replacement of custom configured database to replicate in the report for external locations ([#296](#296)).
* Removed redundant `notebooks` top-level folder ([#263](#263)).
* Split checking for test failures and linting errors into independent GitHub Actions checks ([#287](#287)).
* Verify query metadata for assessment dashboards during unit tests ([#294](#294)).
@nfx nfx mentioned this pull request Sep 29, 2023
Merged
nfx added a commit that referenced this pull request Sep 29, 2023
@nfx
Release v0.2.0 (#328)
b81abea 
# Version changelog

## 0.2.0

* Added retrieving for all account-level groups with matching names to
workspace-level groups in case no explicit configuration
([#277](#277)).
* Added crawler for Azure Service principals used for direct storage
access ([#305](#305)).
* Added more SQL queries to the assessment step dashboard
([#269](#269)).
* Added filtering out for job clusters in the clusters crawler
([#298](#298)).
* Added recording errors from `crawl_tables` step in
`$inventory.table_failures` table and display counter on the dashboard
([#300](#300)).
* Added comprehensive introduction user manual
([#273](#273)).
* Added interactive tutorial for local group migration readme
([#291](#291)).
* Added tutorial links to the landing page of documentation
([#290](#290)).
* Added (internal) support for account-level configuration and
multi-cloud workspace list
([#264](#264)).
* Improved order of tasks in the README notebook
([#286](#286)).
* Improved installation script to run in a Windows Git Bash terminal
([#282](#282)).
* Improved installation script by setting log level to uppercase by
default ([#271](#271)).
* Improved installation finish messages within installer script
([#267](#267)).
* Improved automation for `MANAGED` table migration and continued
building tables migration component
([#295](#295)).
* Fixed debug notebook code with refactored package structure
([#250](#250))
([#265](#265)).
* Fixed replacement of custom configured database to replicate in the
report for external locations
([#296](#296)).
* Removed redundant `notebooks` top-level folder
([#263](#263)).
* Split checking for test failures and linting errors into independent
GitHub Actions checks
([#287](#287)).
* Verify query metadata for assessment dashboards during unit tests
([#294](#294)).
FastLee pushed a commit that referenced this pull request Sep 29, 2023
@nfx @FastLee
Release v0.2.0 (#328)
b6015a6 
# Version changelog

## 0.2.0

* Added retrieving for all account-level groups with matching names to
workspace-level groups in case no explicit configuration
([#277](#277)).
* Added crawler for Azure Service principals used for direct storage
access ([#305](#305)).
* Added more SQL queries to the assessment step dashboard
([#269](#269)).
* Added filtering out for job clusters in the clusters crawler
([#298](#298)).
* Added recording errors from `crawl_tables` step in
`$inventory.table_failures` table and display counter on the dashboard
([#300](#300)).
* Added comprehensive introduction user manual
([#273](#273)).
* Added interactive tutorial for local group migration readme
([#291](#291)).
* Added tutorial links to the landing page of documentation
([#290](#290)).
* Added (internal) support for account-level configuration and
multi-cloud workspace list
([#264](#264)).
* Improved order of tasks in the README notebook
([#286](#286)).
* Improved installation script to run in a Windows Git Bash terminal
([#282](#282)).
* Improved installation script by setting log level to uppercase by
default ([#271](#271)).
* Improved installation finish messages within installer script
([#267](#267)).
* Improved automation for `MANAGED` table migration and continued
building tables migration component
([#295](#295)).
* Fixed debug notebook code with refactored package structure
([#250](#250))
([#265](#265)).
* Fixed replacement of custom configured database to replicate in the
report for external locations
([#296](#296)).
* Removed redundant `notebooks` top-level folder
([#263](#263)).
* Split checking for test failures and linting errors into independent
GitHub Actions checks
([#287](#287)).
* Verify query metadata for assessment dashboards during unit tests
([#294](#294)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfx nfx nfx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keep order of tasks in the README notebook
2 participants
@larsgeorge-db @nfx