Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added current version of UCX to task logs #566

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

The5cheduler
Copy link
Contributor

Resolves #539

@nfx nfx added the pr/do-not-merge this pull request is not ready to merge label Nov 8, 2023
@nfx
Copy link
Contributor

nfx commented Nov 8, 2023

CLA required

@The5cheduler The5cheduler marked this pull request as ready for review November 9, 2023 01:02
@The5cheduler The5cheduler requested a review from a team November 9, 2023 01:02
@The5cheduler
Copy link
Contributor Author

CLA required

Not sure how can I sign that.
Contribution file, If you can please show me I can update the Contribution Markdown as well.

@nfx nfx added the pr/cla-required CLA signature is required label Nov 9, 2023
@CLAassistant
Copy link

CLAassistant commented Nov 27, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (92905fe) 82.78% compared to head (1e63a8b) 82.78%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/databricks/labs/ucx/framework/tasks.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #566   +/-   ##
=======================================
  Coverage   82.78%   82.78%           
=======================================
  Files          35       35           
  Lines        3515     3515           
  Branches      656      656           
=======================================
  Hits         2910     2910           
  Misses        459      459           
  Partials      146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfx
Copy link
Contributor

nfx commented Nov 27, 2023

@The5cheduler please rebase on the latest main branch and push again

@The5cheduler
Copy link
Contributor Author

@The5cheduler please rebase on the latest main branch and push again

performed that couple of minutes ago in commit 1e63a8b

@nfx nfx changed the title Better Logs Readability by including current version of UCX Added current version of UCX to task logs Nov 27, 2023
@nfx nfx merged commit 1b42036 into databrickslabs:main Nov 27, 2023
5 of 7 checks passed
nfx added a commit that referenced this pull request Nov 28, 2023
 * Added current version of UCX to task logs ([#566](#566)).
 * Fixed external locations widget to return hostname for `jdbc:`-sourced tables ([#621](#621)).
 * Fixed `'str' object has no attribute 'value'` failure on apply backup group permissions task ([#574](#574)).
 * Fixed `crawl_cluster` failure over custom runtimes ([#602](#602)).
 * Fixed `databricks labs ucx workflows` command ([#608](#608)).
 * Fixed problematic integration test fixture `make_ucx_group` ([#613](#613)).
 * Fixed internal API request retry logic by relying on concrete exception types ([#637](#637)).
 * Fixed `tables.scala` notebook to read inventory database from `~/.ucx/config.yml` file ([#614](#614)).
 * Introduced `StaticTablesCrawler` for integration tests ([#632](#632)).
 * Reduced runtime of `test_set_owner_permission` from 15 minutes to 44 seconds ([#636](#636)).
 * Updated `LICENSE` ([#643](#643)).
 * Updated documentation ([#611](#611), [#646](#646)).
@nfx nfx mentioned this pull request Nov 28, 2023
nfx added a commit that referenced this pull request Nov 28, 2023
* Added current version of UCX to task logs
([#566](#566)).
* Fixed `'str' object has no attribute 'value'` failure on apply backup
group permissions task
([#574](#574)).
* Fixed `crawl_cluster` failure over custom runtimes
([#602](#602)).
* Fixed `databricks labs ucx workflows` command
([#608](#608)).
* Fixed problematic integration test fixture `make_ucx_group`
([#613](#613)).
* Fixed internal API request retry logic by relying on concrete
exception types
([#637](#637)).
* Fixed `tables.scala` notebook to read inventory database from
`~/.ucx/config.yml` file.
([#614](#614)).
* Introduced `StaticTablesCrawler` for integration tests
([#632](#632)).
* Reduced runtime of `test_set_owner_permission` from 15 minutes to 44
seconds ([#636](#636)).
* Updated `LICENSE`
([#643](#643)).
* Updated documentation
([#611](#611),
[#646](#646)).

**Breaking changes** (existing installations need to remove `ucx`
database, reinstall UCX and re-run assessment jobs)
* Fixed external locations widget to return hostname for `jdbc:`-sourced
tables ([#621](#621)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/cla-required CLA signature is required pr/do-not-merge this pull request is not ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add version info when logs are created
3 participants