Fixed problematic integration test fixture make_ucx_group #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmoore247
had a problem deploying
to
account-admin
GitHub Actions
Failure
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
- Coverage 82.87% 82.80% -0.08%
==========================================
Files 35 35
Lines 3504 3507 +3
Branches 652 654 +2
==========================================
Hits 2904 2904
- Misses 456 458 +2
- Partials 144 145 +1 ☔ View full report in Codecov by Sentry. |
dmoore247
had a problem deploying
to
account-admin
GitHub Actions
Error
dmoore247
had a problem deploying
to
account-admin
GitHub Actions
Failure
dmoore247
changed the title
dmoore247
had a problem deploying
to
account-admin
GitHub Actions
Failure
nfx
approved these changes
Nov 22, 2023
HariGS-DB
pushed a commit
that referenced
this pull request
Nov 22, 2023
Found test fixture generating 7+ local integration test failures. Adding to test in isolation.
pritishpai
pushed a commit
that referenced
this pull request
Nov 22, 2023
Found test fixture generating 7+ local integration test failures. Adding to test in isolation.
nfx
added a commit
that referenced
this pull request
Nov 28, 2023
* Added current version of UCX to task logs ([#566](#566)). * Fixed external locations widget to return hostname for `jdbc:`-sourced tables ([#621](#621)). * Fixed `'str' object has no attribute 'value'` failure on apply backup group permissions task ([#574](#574)). * Fixed `crawl_cluster` failure over custom runtimes ([#602](#602)). * Fixed `databricks labs ucx workflows` command ([#608](#608)). * Fixed problematic integration test fixture `make_ucx_group` ([#613](#613)). * Fixed internal API request retry logic by relying on concrete exception types ([#637](#637)). * Fixed `tables.scala` notebook to read inventory database from `~/.ucx/config.yml` file ([#614](#614)). * Introduced `StaticTablesCrawler` for integration tests ([#632](#632)). * Reduced runtime of `test_set_owner_permission` from 15 minutes to 44 seconds ([#636](#636)). * Updated `LICENSE` ([#643](#643)). * Updated documentation ([#611](#611), [#646](#646)).
Merged
nfx
added a commit
that referenced
this pull request
Nov 28, 2023
* Added current version of UCX to task logs ([#566](#566)). * Fixed `'str' object has no attribute 'value'` failure on apply backup group permissions task ([#574](#574)). * Fixed `crawl_cluster` failure over custom runtimes ([#602](#602)). * Fixed `databricks labs ucx workflows` command ([#608](#608)). * Fixed problematic integration test fixture `make_ucx_group` ([#613](#613)). * Fixed internal API request retry logic by relying on concrete exception types ([#637](#637)). * Fixed `tables.scala` notebook to read inventory database from `~/.ucx/config.yml` file. ([#614](#614)). * Introduced `StaticTablesCrawler` for integration tests ([#632](#632)). * Reduced runtime of `test_set_owner_permission` from 15 minutes to 44 seconds ([#636](#636)). * Updated `LICENSE` ([#643](#643)). * Updated documentation ([#611](#611), [#646](#646)). **Breaking changes** (existing installations need to remove `ucx` database, reinstall UCX and re-run assessment jobs) * Fixed external locations widget to return hostname for `jdbc:`-sourced tables ([#621](#621)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found test fixture generating 7+ local integration test failures. Adding to test in isolation.