Improved installation failure with actionable message #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prajin-29
temporarily deployed
to
account-admin
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
==========================================
+ Coverage 85.67% 85.76% +0.09%
==========================================
Files 42 42
Lines 5311 5318 +7
Branches 969 970 +1
==========================================
+ Hits 4550 4561 +11
+ Misses 542 539 -3
+ Partials 219 218 -1 ☔ View full report in Codecov by Sentry. |
prajin-29
had a problem deploying
to
account-admin
GitHub Actions
Failure
prajin-29
had a problem deploying
to
account-admin
GitHub Actions
Failure
nfx
requested changes
Jan 25, 2024
src/databricks/labs/ucx/install.py
Outdated
| self._sql_backend = StatementExecutionBackend(self._ws, self.current_config.warehouse_id) | ||
| deploy_schema(self._sql_backend, self.current_config.inventory_database) | ||
| except BadRequest as ex: | ||
| if "UNRESOLVED_COLUMN.WITH_SUGGESTION" in str(ex): |
There was a problem hiding this comment.
the goal is is to raise a more informative exception - not just do a naive log, not to swallow it (which is even worse).
There was a problem hiding this comment.
Now if this exception happens it will error out with proper message.
prajin-29
had a problem deploying
to
account-admin
GitHub Actions
Failure
prajin-29
had a problem deploying
to
account-admin
GitHub Actions
Failure
prajin-29
had a problem deploying
to
account-admin
GitHub Actions
Failure
prajin-29
temporarily deployed
to
account-admin
GitHub Actions
Inactive
nfx
approved these changes
Jan 29, 2024
nfx
changed the title
nfx
added a commit
that referenced
this pull request
Feb 1, 2024
* Added "what" property for migration to scope down table migrations ([#856](#856)). * Added job count in the assessment dashboard ([#858](#858)). * Adopted `installation` package from `databricks-labs-blueprint` ([#860](#860)). * Debug logs to print only the first 96 bytes of SQL query by default, tunable by `debug_truncate_bytes` SDK configuration property ([#859](#859)). * Extract command codes and unify the checks for spark_conf, cluster_policy, init_scripts ([#855](#855)). * Improved installation failure with actionable message ([#840](#840)). * Improved validating groups membership cli command ([#816](#816)). Dependency updates: * Updated databricks-labs-blueprint requirement from ~=0.1.0 to ~=0.2.4 ([#867](#867)).
Merged
nfx
added a commit
that referenced
this pull request
Feb 1, 2024
* Added "what" property for migration to scope down table migrations ([#856](#856)). * Added job count in the assessment dashboard ([#858](#858)). * Adopted `installation` package from `databricks-labs-blueprint` ([#860](#860)). * Debug logs to print only the first 96 bytes of SQL query by default, tunable by `debug_truncate_bytes` SDK configuration property ([#859](#859)). * Extract command codes and unify the checks for spark_conf, cluster_policy, init_scripts ([#855](#855)). * Improved installation failure with actionable message ([#840](#840)). * Improved validating groups membership cli command ([#816](#816)). Dependency updates: * Updated databricks-labs-blueprint requirement from ~=0.1.0 to ~=0.2.4 ([#867](#867)).
dmoore247
pushed a commit
that referenced
this pull request
Mar 23, 2024
dmoore247
pushed a commit
that referenced
this pull request
Mar 23, 2024
* Added "what" property for migration to scope down table migrations ([#856](#856)). * Added job count in the assessment dashboard ([#858](#858)). * Adopted `installation` package from `databricks-labs-blueprint` ([#860](#860)). * Debug logs to print only the first 96 bytes of SQL query by default, tunable by `debug_truncate_bytes` SDK configuration property ([#859](#859)). * Extract command codes and unify the checks for spark_conf, cluster_policy, init_scripts ([#855](#855)). * Improved installation failure with actionable message ([#840](#840)). * Improved validating groups membership cli command ([#816](#816)). Dependency updates: * Updated databricks-labs-blueprint requirement from ~=0.1.0 to ~=0.2.4 ([#867](#867)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixing Installation Failure with actionable message
Linked issues
closes #835
Resolves #835
Functionality
databricks labs ucx .........Tests