Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Job Count in the Dashboard #858

Merged
merged 7 commits into from
Feb 1, 2024
Merged

Added Job Count in the Dashboard #858

merged 7 commits into from
Feb 1, 2024

Conversation

prajin-29
Copy link
Contributor

@prajin-29 prajin-29 commented Jan 30, 2024

Changes

Added one more sql for calculating the Total Job Count.

Linked issues

close: #826

Resolves #826

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command: databricks labs ucx ...
  • added a new workflow
  • modified existing workflow: ...
  • added a new table
  • modified existing table: ...

Tests

Screenshot 2024-02-01 at 12 03 08 PM
  • manually tested
  • added unit tests
  • added integration tests
  • verified on staging environment (screenshot attached)

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3042857) 85.85% compared to head (f78bed6) 85.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #858   +/-   ##
=======================================
  Coverage   85.85%   85.85%           
=======================================
  Files          42       42           
  Lines        5394     5394           
  Branches      978      978           
=======================================
  Hits         4631     4631           
  Misses        546      546           
  Partials      217      217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prajin-29
Copy link
Contributor Author

@nfx . Should I move the Job Count to the second row and the subsequent dashboard to 1 row down?

@nfx
Copy link
Collaborator

nfx commented Jan 30, 2024

@prajin-29 whatever makes it look consistent:) provide screenshots

@nfx
Copy link
Collaborator

nfx commented Jan 31, 2024

@prajin-29 that empty spot looks weird. Can we make something wider?

@prajin-29
Copy link
Contributor Author

@prajin-29 that empty spot looks weird. Can we make something wider?

@nfx . Updated the dimension.

@nfx nfx merged commit 0d214ee into main Feb 1, 2024
6 of 7 checks passed
@nfx nfx deleted the feature/job_count branch February 1, 2024 19:53
nfx added a commit that referenced this pull request Feb 1, 2024
* Added "what" property for migration to scope down table migrations ([#856](#856)).
* Added job count in the assessment dashboard ([#858](#858)).
* Adopted `installation` package from `databricks-labs-blueprint` ([#860](#860)).
* Debug logs to print only the first 96 bytes of SQL query by default, tunable by `debug_truncate_bytes` SDK configuration property ([#859](#859)).
* Extract command codes and unify the checks for spark_conf, cluster_policy, init_scripts ([#855](#855)).
* Improved installation failure with actionable message ([#840](#840)).
* Improved validating groups membership cli command ([#816](#816)).

Dependency updates:

 * Updated databricks-labs-blueprint requirement from ~=0.1.0 to ~=0.2.4 ([#867](#867)).
@nfx nfx mentioned this pull request Feb 1, 2024
nfx added a commit that referenced this pull request Feb 1, 2024
* Added "what" property for migration to scope down table migrations
([#856](#856)).
* Added job count in the assessment dashboard
([#858](#858)).
* Adopted `installation` package from `databricks-labs-blueprint`
([#860](#860)).
* Debug logs to print only the first 96 bytes of SQL query by default,
tunable by `debug_truncate_bytes` SDK configuration property
([#859](#859)).
* Extract command codes and unify the checks for spark_conf,
cluster_policy, init_scripts
([#855](#855)).
* Improved installation failure with actionable message
([#840](#840)).
* Improved validating groups membership cli command
([#816](#816)).

Dependency updates:

* Updated databricks-labs-blueprint requirement from ~=0.1.0 to ~=0.2.4
([#867](#867)).
dmoore247 pushed a commit that referenced this pull request Mar 23, 2024
## Changes
Added one more sql for calculating the Total Job Count.

### Linked issues
close: #826 

Resolves #826 


### Functionality 

- [ ] added relevant user documentation
- [ ] added new CLI command
- [ ] modified existing command: `databricks labs ucx ...`
- [ ] added a new workflow
- [ ] modified existing workflow: `...`
- [ ] added a new table
- [ ] modified existing table: `...`

### Tests
<img width="1553" alt="Screenshot 2024-02-01 at 12 03 08 PM"
src="https://github.com/databrickslabs/ucx/assets/127273819/c7900423-354c-45e0-973f-b3539b5dd97c">




- [x] manually tested
- [ ] added unit tests
- [ ] added integration tests
- [ ] verified on staging environment (screenshot attached)
dmoore247 pushed a commit that referenced this pull request Mar 23, 2024
* Added "what" property for migration to scope down table migrations
([#856](#856)).
* Added job count in the assessment dashboard
([#858](#858)).
* Adopted `installation` package from `databricks-labs-blueprint`
([#860](#860)).
* Debug logs to print only the first 96 bytes of SQL query by default,
tunable by `debug_truncate_bytes` SDK configuration property
([#859](#859)).
* Extract command codes and unify the checks for spark_conf,
cluster_policy, init_scripts
([#855](#855)).
* Improved installation failure with actionable message
([#840](#840)).
* Improved validating groups membership cli command
([#816](#816)).

Dependency updates:

* Updated databricks-labs-blueprint requirement from ~=0.1.0 to ~=0.2.4
([#867](#867)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Job total number of jobs and not just the incompatible job count.
2 participants