Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing frontend Ember app (i.e. datahub-web folder) #2921

Merged
merged 3 commits into from
Jul 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 0 additions & 1 deletion .dockerignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
**/node_modules/
datahub-web/build/
datahub-frontend/build/
metadata-ingestion/venv/
out
Expand Down
16 changes: 8 additions & 8 deletions datahub-frontend/README.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# DataHub Frontend
DataHub frontend is a [Play](https://www.playframework.com/) service written in Java. It is served as a mid-tier
between [DataHub GMS](../gms) which is the backend service and [DataHub Web](../datahub-web).
kafkahw marked this conversation as resolved.
Show resolved Hide resolved
between [DataHub GMS](../gms) which is the backend service and [DataHub Web](../datahub-web-react/README.md).

## Pre-requisites
* You need to have [JDK8](https://www.oracle.com/java/technologies/jdk8-downloads.html)
* You need to have [JDK8](https://www.oracle.com/java/technologies/jdk8-downloads.html)
installed on your machine to be able to build `DataHub Frontend`.
* You need to have [Chrome](https://www.google.com/chrome/) web browser
* You need to have [Chrome](https://www.google.com/chrome/) web browser
installed to be able to build because UI tests have a dependency on `Google Chrome`.

## Build
Expand All @@ -19,12 +19,12 @@ However, if you only want to build `DataHub Frontend` specifically:
```

## Dependencies
Before starting `DataHub Frontend`, you need to make sure that [DataHub GMS](../gms) and
Before starting `DataHub Frontend`, you need to make sure that [DataHub GMS](../gms) and
all its dependencies have already started and running.

Also, user information should already be registered into the DB,
otherwise user will not be able to sign in.
To do that, first create a file named `user.dat` containing below line and filling the parts `<<something>>`
otherwise user will not be able to sign in.
To do that, first create a file named `user.dat` containing below line and filling the parts `<<something>>`
with your information:
```
{"auditHeader": None, "proposedSnapshot": ("com.linkedin.pegasus2avro.metadata.snapshot.CorpUserSnapshot", {"urn": "urn:li:corpuser:<<username>>", "aspects": [{"active": True, "fullName": "<<Full Name>>", "email": "<<e-mail address>>"}, {}]}), "proposedDelta": None}
Expand Down Expand Up @@ -52,7 +52,7 @@ cd datahub-frontend/run && ./run-local-frontend
```

## Checking out DataHub UI
After starting your application in one of the two ways mentioned above, you can connect to it by typing below
After starting your application in one of the two ways mentioned above, you can connect to it by typing below
into your favorite web browser:
```
http://localhost:9001
Expand Down Expand Up @@ -321,7 +321,7 @@ WHZ-Authentication {

### Authentication in React
The React app supports both JAAS as described above and separately OIDC authentication. To learn about configuring OIDC for React,
see the [OIDC in React](../docs/how/auth/sso/configure-oidc-react.md) document.
see the [OIDC in React](../docs/how/auth/sso/configure-oidc-react.md) document.


### API Debugging
Expand Down
8 changes: 4 additions & 4 deletions datahub-web-react/src/app/analytics/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Currently, configuring an analytics provider requires that you fork DataHub & mo

### Mixpanel

1. Open `datahub-web/src/conf/analytics.ts`
1. Open `datahub-web-react/src/conf/analytics.ts`
2. Uncomment the `mixpanel` field within the `config` object.
3. Replace the sample `token` with the API token provided by Mixpanel.
4. Rebuild & redeploy `datahub-frontend-react` to start tracking.
Expand All @@ -33,7 +33,7 @@ const config: any = {

### Amplitude

1. Open `datahub-web/src/conf/analytics.ts`
1. Open `datahub-web-react/src/conf/analytics.ts`
2. Uncomment the `amplitude` field within the `config` object.
3. Replace the sample `apiKey` with the key provided by Amplitude.
4. Rebuild & redeploy `datahub-frontend-react` to start tracking.
Expand All @@ -53,7 +53,7 @@ const config: any = {
- This plugin requires use of Univeral Analytics and does not yet support GA4. To create a Universal Analytics Property, follow [this guide](https://www.analyticsmania.com/other-posts/how-to-create-a-universal-analytics-property/).
- Google Analytics lacks robust support for custom event properties. For that reason many of the DataHub events discussed above will not be fully populated. Instead, we map certain fields of the DataHub event to the standard `category`, `action`, `label` fields required by GA.

1. Open `datahub-web/src/conf/analytics.ts`
1. Open `datahub-web-react/src/conf/analytics.ts`
2. Uncomment the `googleAnalytics` field within the `config` object.
3. Replace the sample `trackingId` with the one provided by Google Analytics.
4. Rebuild & redeploy `datahub-frontend-react` to start tracking.
Expand Down Expand Up @@ -145,7 +145,7 @@ analytics.event({ type: EventType.MyNewEvent, ...my event fields });

To log events to the console for debugging / verification purposes

1. Open `datahub-web/src/conf/analytics.ts`
1. Open `datahub-web-react/src/conf/analytics.ts`
2. Uncomment `logging: true` within the `config` object.
3. Rebuild & redeploy `datahub-frontend-react` to start logging all events to your browser's console.

Expand Down
48 changes: 0 additions & 48 deletions datahub-web/.eslintignore

This file was deleted.

85 changes: 0 additions & 85 deletions datahub-web/.eslintrc.js

This file was deleted.

24 changes: 0 additions & 24 deletions datahub-web/.eslintrc.precommit.js

This file was deleted.

28 changes: 0 additions & 28 deletions datahub-web/.gitignore

This file was deleted.

4 changes: 0 additions & 4 deletions datahub-web/.prettierrc

This file was deleted.

10 changes: 0 additions & 10 deletions datahub-web/.template-lintrc.js

This file was deleted.

20 changes: 0 additions & 20 deletions datahub-web/@datahub/data-models/.editorconfig

This file was deleted.

9 changes: 0 additions & 9 deletions datahub-web/@datahub/data-models/.ember-cli

This file was deleted.

23 changes: 0 additions & 23 deletions datahub-web/@datahub/data-models/.gitignore

This file was deleted.

29 changes: 0 additions & 29 deletions datahub-web/@datahub/data-models/.npmignore

This file was deleted.

Loading