Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing frontend Ember app (i.e. datahub-web folder) #2921

Merged
merged 3 commits into from
Jul 22, 2021
Merged

Removing frontend Ember app (i.e. datahub-web folder) #2921

merged 3 commits into from
Jul 22, 2021

Conversation

kafkahw
Copy link
Contributor

@kafkahw kafkahw commented Jul 21, 2021

Removing frontend ember app (i.e. datahub-web folder) as announced in DataHub slack channel one month ago.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@hsheth2 hsheth2 mentioned this pull request Jul 21, 2021
Merged
4 tasks
@kafkahw
Copy link
Contributor Author

kafkahw commented Jul 21, 2021

@shirshanka @jjoyce0510 @gabe-lyons I think I've fixed the doc generation issue. Running ./gradlew :docs-website:yarnBuild locally seems to be fine now. Can you guys please help approve running workflows? I think as a first-time contributor I can't approve it.

hsheth2
hsheth2 approved these changes Jul 21, 2021
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the build passes, LGTM

Super exciting!!

datahub-frontend/README.md Show resolved Hide resolved
shirshanka
shirshanka approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit bac1ae4 into datahub-project:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kafkahw @shirshanka @hsheth2