Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingestion): pin snowflake sqlalchemy connector #2923

Merged
merged 1 commit into from
Jul 21, 2021
Merged

fix(ingestion): pin snowflake sqlalchemy connector #2923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions metadata-ingestion/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ def get_long_description():
"postgres": sql_common | {"psycopg2-binary", "GeoAlchemy2"},
"redshift": sql_common | {"sqlalchemy-redshift", "psycopg2-binary", "GeoAlchemy2"},
"sagemaker": aws_common,
"snowflake": sql_common | {"snowflake-sqlalchemy"},
"snowflake-usage": sql_common | {"snowflake-sqlalchemy"},
"snowflake": sql_common | {"snowflake-sqlalchemy<=1.2.4"},
"snowflake-usage": sql_common | {"snowflake-sqlalchemy<=1.2.4"},
"superset": {"requests"},
}

Expand Down Expand Up @@ -188,6 +188,7 @@ def get_long_description():
"mongodb",
"mssql",
"mysql",
"snowflake",
]
for dependency in plugins[plugin]
),
Expand Down
5 changes: 4 additions & 1 deletion metadata-ingestion/tests/unit/test_snowflake_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
from datahub.ingestion.source.snowflake import SnowflakeConfig
import pytest


@pytest.mark.integration
def test_snowflake_uri():
from datahub.ingestion.source.snowflake import SnowflakeConfig

config = SnowflakeConfig.parse_obj(
{
"username": "user",
Expand Down