fix(ingestion): pin snowflake sqlalchemy connector #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.2.5 was released today (https://pypi.org/project/snowflake-sqlalchemy/1.2.5/), but yields errors for us, as below. Since this is breaking CI, we pin our version to 1.2.4 for now. ``` tests/unit/test_snowflake_source.py:1: in <module> from datahub.ingestion.source.snowflake import SnowflakeConfig src/datahub/ingestion/source/snowflake.py:7: in <module> import snowflake.sqlalchemy # noqa: F401 venv/lib/python3.8/site-packages/snowflake/sqlalchemy/__init__.py:25: in <module> from . import base, snowdialect venv/lib/python3.8/site-packages/snowflake/sqlalchemy/base.py:17: in <module> from .custom_commands import AWSBucket, AzureContainer, ExternalStage venv/lib/python3.8/site-packages/snowflake/sqlalchemy/custom_commands.py:14: in <module> from sqlalchemy.sql.roles import FromClauseRole E ModuleNotFoundError: No module named 'sqlalchemy.sql.roles' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.2.5 was released today (https://pypi.org/project/snowflake-sqlalchemy/1.2.5/), but yields errors for us, as below. We pin our version to 1.2.4 for now, since we still depend on SQLAlchemy 1.3.24.
This issue is breaking the build for a couple other PRs:
See snowflakedb/snowflake-sqlalchemy#234 for details about this issue.
Checklist