Skip to content

Commit

Permalink
Cherry-pick Fixes for apache#22163 and apache#22184
Browse files Browse the repository at this point in the history
  • Loading branch information
nikhil-ctds committed Mar 11, 2024
1 parent 1fd3aab commit f33d2c5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ private void setTransformFunctionPackageLocation(Function.FunctionMetaData.Build
try {
String builtin = functionDetails.getBuiltin();
if (isBlank(builtin)) {
functionPackageFile = getPackageFile(transformFunction);
functionPackageFile = getPackageFile(componentType, transformFunction);
}
Function.PackageLocationMetaData.Builder functionPackageLocation =
getFunctionPackageLocation(functionMetaDataBuilder.build(),
Expand Down Expand Up @@ -716,7 +716,7 @@ private Function.FunctionDetails validateUpdateRequestParams(final String tenant
transformFunctionPackage =
getBuiltinFunctionPackage(sinkConfig.getTransformFunction());
if (transformFunctionPackage == null) {
File functionPackageFile = getPackageFile(sinkConfig.getTransformFunction());
File functionPackageFile = getPackageFile(componentType, sinkConfig.getTransformFunction());
transformFunctionPackage =
new FunctionFilePackage(functionPackageFile, workerConfig.getNarExtractionDirectory(),
workerConfig.getEnableClassloadingOfExternalFiles(), ConnectorDefinition.class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -361,12 +361,6 @@ public class ProxyConfiguration implements PulsarConfiguration {
)
private boolean enableProxyStatsEndpoints = true;

@FieldContext(
category = CATEGORY_HTTP,
doc = "Whether to enable the proxy's /metrics, /proxy-stats, and /status.html http endpoints"
)
private boolean enableProxyStatsEndpoints = true;

@FieldContext(
category = CATEGORY_AUTHENTICATION,
doc = "Whether the '/metrics' endpoint requires authentication. Defaults to true."
Expand Down

0 comments on commit f33d2c5

Please sign in to comment.