Merge pull request #44 from kvld/kvld-patch-1

Make isTopLevelFailure property optional
davidahouse · Nov 6, 2022 · 3c82063 · 3c82063
2 parents 21ba268 + 241748a
commit 3c82063
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/Sources/XCResultKit/Schema/ActionTestExpectedFailure.swift b/Sources/XCResultKit/Schema/ActionTestExpectedFailure.swift
@@ -22,15 +22,10 @@ public struct ActionTestExpectedFailure: XCResultObject {
     public let failureSummary: ActionTestFailureSummary?
     public let isTopLevelFailure: Bool
 
-    public init?(_ json: [String: AnyObject]) {
-        do {
-            uuid = xcOptional(element: "uuid", from: json)
-            failureReason = xcOptional(element: "failureReason", from: json)
-            failureSummary = xcOptional(element: "failureSummary", from: json)
-            isTopLevelFailure = try xcRequired(element: "isTopLevelFailure", from: json)
-        } catch {
-            logError("Error parsing ActionTestExpectedFailure: \(error.localizedDescription)")
-            return nil
-        }
+    public init(_ json: [String: AnyObject]) {
+        uuid = xcOptional(element: "uuid", from: json)
+        failureReason = xcOptional(element: "failureReason", from: json)
+        failureSummary = xcOptional(element: "failureSummary", from: json)
+        isTopLevelFailure = xcOptional(element: "isTopLevelFailure", from: json) ?? false
     }
 }
diff --git a/Sources/XCResultKit/Schema/ActionTestFailureSummary.swift b/Sources/XCResultKit/Schema/ActionTestFailureSummary.swift
@@ -49,7 +49,7 @@ public struct ActionTestFailureSummary: XCResultObject {
             associatedError = xcOptional(element: "associatedError", from: json)
             sourceCodeContext = xcOptional(element: "sourceCodeContext", from: json)
             timestamp = xcOptional(element: "timestamp", from: json)
-            isTopLevelFailure = try xcRequired(element: "isTopLevelFailure", from: json)
+            isTopLevelFailure = xcOptional(element: "isTopLevelFailure", from: json) ?? false
         } catch {
             logError("Error parsing ActionTestExpectedFailure: \(error.localizedDescription)")
             return nil