Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make isTopLevelFailure property optional #44

Merged
merged 2 commits into from
Nov 6, 2022
Merged

Make isTopLevelFailure property optional #44

merged 2 commits into from
Nov 6, 2022

Conversation

kvld
Copy link
Contributor

@kvld kvld commented Nov 6, 2022

Property isTopLevelFailure should be optional in both ActionTestExpectedFailure and ActionTestFailureSummary.

Here is an example of test case and extracted info:

Screen Shot 2022-11-06 at 15 18 44

https://gist.github.com/kvld/5d269d2d9eaef66e9013bb137d3c902c

In the case of failures in substeps, property isTopLevelFailure is missed (because of default value), so XCResultKit will throw an error.

@davidahouse davidahouse self-requested a review November 6, 2022 12:46
davidahouse
davidahouse approved these changes Nov 6, 2022
View reviewed changes
Copy link
Owner

@davidahouse davidahouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I thought there might be some more fields that didn't need to be required. The spec doesn't always match reality. Thanks for the patch!

@davidahouse davidahouse merged commit 3c82063 into davidahouse:main Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidahouse davidahouse davidahouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvld @davidahouse