Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ActionTestFailureSummary for Xcode 14 and introduce Sourcery #43

Closed
wants to merge 0 commits into from

Conversation

tylervick
Copy link
Contributor

Background:
xcresulttool 3.39 removed com.apple.dt.xctest.activity-type.testAssertionFailure from ActionTestSummary, meaning we're now more reliant on ActionTestFailureSummary to provide failure details.

Changes:

  • Update ActionTestFailureSummary to include:
    • uuid
    • issueType
    • detailedDescription
    • attachments
    • sourceCodeContext
    • timestamp
    • isTopLevelFailure
  • Introduce Sourcery to automatically generate initializers
  • Create XCResultObjectGenerated protocol to generate XCResultObject conformance

Test:

  • Verify no regression to xcresult parsing for successful runs
  • Verify ActionTestFailureSummary is populated with all available failure data

@davidahouse
Copy link
Owner

@tylervick Thanks for the PR! Check out #42 also as I added all the latest objects & fields that Xcode 14 is using. That does have the changes to ActionTestFailureSummary added.

I'm almost thinking what we should do is create a release with all the new fields (possibly from #42), then move the Sourcery changes as a separate bit of work so we can have time to refine that implementation. And chat more about using Sourcery long term. But open to other ideas.

@tylervick
Copy link
Contributor Author

Hey @davidahouse thanks for the quick review! I agree with this rollout plan - there's also potential to generate the base objects as well after parsing the output from xcresulttool.

Let me know if I can be of any help with the WIP PR - thanks again!

@davidahouse
Copy link
Owner

@tylervick I've merged in the update for Xcode 14 and cut a new release v1.0.0. I think next step I'd like to take a stab at generating the models from the schema export from xcresulttool (as you mentioned above). I think we can have just a simple standalone app that can generate this. Need to decide if it belongs in this repo, or a separate one however. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants