Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial fix for the negative virtual static method tests #17

Merged
merged 3 commits into from
May 12, 2021
Merged

Partial fix for the negative virtual static method tests #17

merged 3 commits into from
May 12, 2021

Commits on May 12, 2021

  1. Partial fix for the negative virtual static methods 

    1) UnimplementedAbstractMethodOnConcreteClass - I have added logic
to verify that all SVMs are implemented once a class is fully loaded.
That required me to propagate a new flag around limiting the class
load level for methods, otherwise we were hitting stack overflows
in many of the tests. I have recycled a pre-existing HRESULT ID which
is probably not what we want, I just didn't want to churn the codebase
before hearing from you what is the right way to proceed here.

2) UnimplementedAbstractMethodOnAbstractClass - the one remaining
failing case is 'ConstraintCheckShouldFail' - I guess that corresponds
to what you alluded to in mentioning that we're not properly checking
class constraints yet.

3) MultipleMethodImplRecordsSameMethodDecl - I added an extra parameter
to the SVM resolution logic that traverses all the MethodImpls and
throws when hitting a duplicate.

The remaining failures involve the following negative tests:

InterfaceVariance (pending my offline feedback)
VarianceSafety (pending my offline feedback)
UnimplementedAbstractMethodOnAbstractClass / ConstraintCheckShouldFail

Thanks

Tomas
    @trylek
    trylek committed May 12, 2021
    Configuration menu
    Copy the full SHA
    f098bc9 View commit details
    Browse the repository at this point in the history

  2. Address David's PR feedback

    @trylek
    trylek committed May 12, 2021
    Configuration menu
    Copy the full SHA
    3536ed4 View commit details
    Browse the repository at this point in the history

  3. Add virtual static check to SVM resolution logic

    @trylek
    trylek committed May 12, 2021
    Configuration menu
    Copy the full SHA
    d49f3b0 View commit details
    Browse the repository at this point in the history