Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Added getTransactionReceipt function #106

Merged
merged 12 commits into from
Apr 29, 2022
Merged

Conversation

arimgibson
Copy link
Contributor

@arimgibson arimgibson commented Apr 28, 2022

Closes #21

  • Add getTransaction function
  • Add necessary types
  • Add cleanTransactionReceipt function
  • Add tests to compare to ethers
  • DRY code for parsing RPCTransaction and RPCTransactionReceipt
  • Document TransactionReceipt type
  • Parse and update types of the logs passed through a transaction receipt

@vercel
Copy link

vercel bot commented Apr 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
essential-eth ✅ Ready (Inspect) Visit Preview Apr 29, 2022 at 8:47PM (UTC)

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #106 (47b7be3) into master (13ff58c) will increase coverage by 0.03%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   90.79%   90.82%   +0.03%     
==========================================
  Files          30       31       +1     
  Lines         717      763      +46     
  Branches      202      217      +15     
==========================================
+ Hits          651      693      +42     
- Misses         61       64       +3     
- Partials        5        6       +1     
Impacted Files Coverage Δ
src/classes/utils/fetchers.ts 93.33% <ø> (ø)
src/classes/utils/clean-transaction-receipt.ts 90.00% <90.00%> (ø)
src/providers/BaseProvider.ts 98.11% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a2104d...47b7be3. Read the comment docs.

@dawsbot
Copy link
Owner

dawsbot commented Apr 28, 2022

Very excited to get this merged! Looks nearly ready, just left a few thoughts

@arimgibson
Copy link
Contributor Author

Actually going to move the web3.js testing into a separate issue; it'll require some extra work to restructure the current function that tests for quality

@arimgibson
Copy link
Contributor Author

@dawsbot ready for final review and hopefullly merging!

…109)

* 🧪  Added web3 test to getTransaction

* ⬆ Pre-commit script package updates

* 🧪 Added web3 test to getTransactionReceipt
@dawsbot dawsbot merged commit 26ed8b1 into master Apr 29, 2022
@dawsbot dawsbot deleted the feature/getTransactionReceipt branch April 29, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add provider.getTransactionReceipt function
2 participants