Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Add web3.js tests to getTransaction and getTransactionReceipt #109

Merged
merged 4 commits into from
Apr 29, 2022

Conversation

arimgibson
Copy link
Contributor

@arimgibson arimgibson commented Apr 29, 2022

Closes #107

  • Add web3.js test to getTransaction
  • Add web3.js test to getTransactionReceipt

@vercel
Copy link

vercel bot commented Apr 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
essential-eth ✅ Ready (Inspect) Visit Preview Apr 29, 2022 at 6:56PM (UTC)

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #109 (edb716a) into feature/getTransactionReceipt (b09569a) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head edb716a differs from pull request most recent head 7434e25. Consider uploading reports for the commit 7434e25 to get more accurate results

@@                        Coverage Diff                        @@
##           feature/getTransactionReceipt     #109      +/-   ##
=================================================================
- Coverage                          90.82%   90.79%   -0.04%     
=================================================================
  Files                                 31       30       -1     
  Lines                                763      717      -46     
  Branches                             217      202      -15     
=================================================================
- Hits                                 693      651      -42     
+ Misses                                64       61       -3     
+ Partials                               6        5       -1     
Impacted Files Coverage Δ
src/providers/BaseProvider.ts 97.87% <0.00%> (-0.25%) ⬇️
src/classes/utils/fetchers.ts 93.33% <0.00%> (ø)
src/classes/utils/clean-transaction-receipt.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b09569a...7434e25. Read the comment docs.

@arimgibson arimgibson changed the base branch from master to feature/getTransactionReceipt April 29, 2022 17:14
@arimgibson arimgibson marked this pull request as ready for review April 29, 2022 18:56
@arimgibson arimgibson requested a review from dawsbot April 29, 2022 18:56
@dawsbot dawsbot merged commit 47b7be3 into feature/getTransactionReceipt Apr 29, 2022
@dawsbot dawsbot deleted the fix/web3TransactionTesting branch April 29, 2022 20:46
dawsbot pushed a commit that referenced this pull request Apr 29, 2022
* 📝 Initial documentation for getTransactionReceipt function

* 🧪 Init test for getTransactionReceipt

* 🏷 Create necessary types & clean types file

* ✨ Init function

* Change type names and add byzantium check

* 🧪 Fix and pass test

* 🎨 DRY'd cleanTransaction(Receipt) functions

* 📝Added documentation to TransactionReceipt type

* ⬆️ Pre-commit script package bump

* 📝Added documentation to Log type

* ✨ Parse logs types and final touches on getTransactionReceipt function

* 🧪 Add web3.js tests to `getTransaction` and `getTransactionReceipt` (#109)

* 🧪  Added web3 test to getTransaction

* ⬆ Pre-commit script package updates

* 🧪 Added web3 test to getTransactionReceipt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test getTransaction and getTransactionReceipt against web3.js
2 participants