Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add percentual of satoshis owned by us #14

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

RCasatta
Copy link
Contributor

@RCasatta RCasatta commented Jul 5, 2024

I would like to have this data which convey similar information as GRAPH_SATS but in a more concise way

I tried to do the same as the UPTIME cols for the PERC_US new col, not sure if I did everything since I don't know how to run the python tests

@daywalker90
Copy link
Owner

To run the python tests you can use the github actions that run on a pull request (i have to figure out how to auto run them on this repo but they should run on your own).

Locally you need to install the appropiate pyln-client and pyln-testing python packages for your cln version. Then you need pytest and optionally pytest-xdist to run tests in parallel. Then you can do this from the summars folder:

pytest -n5 tests/test_summars.py

to run 5 tests in parallel. Don't forget to run cargo build first.

I've added formatting to the new column to round the values to one decimal place and fixed the tests and sorting.

image

You think this is what you wanted?

@RCasatta
Copy link
Contributor Author

RCasatta commented Jul 5, 2024

You think this is what you wanted?

Yes, that is perfect, thanks

@daywalker90 daywalker90 merged commit 8503987 into daywalker90:main Jul 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants