Validate --event-time-start is before --event-time-end

.changes/unreleased/Features-20241003-170529.yaml

@@ -0,0 +1,6 @@
+kind: Features
+body: Ensure `--event-time-start` is before `--event-time-end`
+time: 2024-10-03T17:05:29.984398-05:00
+custom:
+  Author: QMalcolm
+  Issue: "10786"

core/dbt/cli/main.py

@@ -187,6 +187,7 @@ def cli(ctx, **kwargs):
 @p.vars
 @requires.postflight
 @requires.preflight
+@p.validate_option_interactions
 @requires.profile
 @requires.project
 @requires.runtime_config
@@ -561,6 +562,7 @@ def parse(ctx, **kwargs):
 @p.vars
 @requires.postflight
 @requires.preflight
+@p.validate_option_interactions
 @requires.profile
 @requires.project
 @requires.runtime_config

core/dbt/cli/params.py

@@ -1,10 +1,13 @@
+from datetime import datetime
+from functools import update_wrapper
 from pathlib import Path
 
 import click
 
 from dbt.cli.option_types import YAML, ChoiceTuple, Package, WarnErrorOptionsType
 from dbt.cli.options import MultiOption
 from dbt.cli.resolvers import default_profiles_dir, default_project_dir
+from dbt.exceptions import DbtRuntimeError
 from dbt.version import get_version_information
 
 add_package = click.option(
@@ -735,3 +738,26 @@
     envvar="DBT_SHOW_RESOURCE_REPORT",
     hidden=True,
 )
+
+
+def validate_option_interactions(func):
+    def wrapper(*args, **kwargs):
+        ctx = args[0]
+        assert isinstance(ctx, click.Context)
+
+        event_time_start = ctx.params.get("event_time_start")
+        if event_time_start is not None:
+            event_time_end = ctx.params.get("event_time_end")
+
+            if event_time_end is not None and event_time_start >= event_time_end:
+                raise DbtRuntimeError(
+                    "Value for `--event-time-start` must be less than `--event-time-end`"
+                )
+            elif event_time_start >= datetime.now():
+                raise DbtRuntimeError(
+                    "Value for `--event-time-start` must be less than the current time if `--event-time-end` is not specififed"
+                )
+
+        return func(*args, **kwargs)
+
+    return update_wrapper(wrapper, func)

tests/functional/cli/test_option_interaction_validations.py

@@ -0,0 +1,55 @@
+from datetime import datetime
+
+import pytest
+from freezegun import freeze_time
+
+from dbt.tests.util import run_dbt
+
+
+class TestEventTimeEndEventTimeStart:
+    @pytest.mark.parametrize(
+        "event_time_start,event_time_end,expect_pass",
+        [
+            ("2024-10-01", "2024-10-02", True),
+            ("2024-10-02", "2024-10-01", False),
+        ],
+    )
+    def test_option_combo(self, project, event_time_start, event_time_end, expect_pass):
+        try:
+            run_dbt(
+                [
+                    "build",
+                    "--event-time-start",
+                    event_time_start,
+                    "--event-time-end",
+                    event_time_end,
+                ]
+            )
+            assert expect_pass
+        except Exception as e:
+            assert (
+                "Value for `--event-time-start` must be less than `--event-time-end`"
+                in e.__str__()
+            )
+            assert not expect_pass
+
+
+class TestEventTimeStartCurrent_time:
+    @pytest.mark.parametrize(
+        "event_time_start,current_time,expect_pass",
+        [
+            ("2024-10-01", "2024-10-02", True),
+            ("2024-10-02", "2024-10-01", False),
+        ],
+    )
+    def test_option_combo(self, project, event_time_start, current_time, expect_pass):
+        with freeze_time(datetime.fromisoformat(current_time)):
+            try:
+                run_dbt(["build", "--event-time-start", event_time_start])
+                assert expect_pass
+            except Exception as e:
+                assert (
+                    "Value for `--event-time-start` must be less than the current time if `--event-time-end` is not specififed"
+                    in e.__str__()
+                )
+                assert not expect_pass