Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update microbatch end_time to the batch_size ceiling #10883

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Update `MicrobatchBuilder.build_end_time` to use `ceiling_timestamp`

3e2b3e2
Select commit
Loading
Failed to load commit list.
Draft

Update microbatch end_time to the batch_size ceiling #10883

Update `MicrobatchBuilder.build_end_time` to use `ceiling_timestamp`
3e2b3e2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 18, 2024 in 0s

83.43% (-5.78%) compared to 8be0635

View this Pull Request on Codecov

83.43% (-5.78%) compared to 8be0635

Details

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.43%. Comparing base (8be0635) to head (3e2b3e2).

❗ There is a different number of reports uploaded between BASE (8be0635) and HEAD (3e2b3e2). Click for more details.

HEAD has 17 uploads less than BASE
Flag BASE (8be0635) HEAD (3e2b3e2)
integration 18 4
unit 3 0
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10883      +/-   ##
==========================================
- Coverage   89.20%   83.43%   -5.78%     
==========================================
  Files         183      183              
  Lines       23438    23445       +7     
==========================================
- Hits        20909    19562    -1347     
- Misses       2529     3883    +1354
Components Coverage Δ
Unit Tests 83.43% <25.00%> (-5.78%) ⬇️
Integration Tests 83.43% <25.00%> (-3.13%) ⬇️
View more details on Codecov