-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect changes to model access, deprecation_date, and latest_version in state:modified #8264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov Report
@@ Coverage Diff @@
## main #8264 +/- ##
==========================================
+ Coverage 86.22% 86.24% +0.01%
==========================================
Files 174 174
Lines 25515 25522 +7
==========================================
+ Hits 22001 22011 +10
+ Misses 3514 3511 -3
|
MichelleArk
changed the title
ModelNode.same_ref_representation
Detect changes to model access, deprecation_date, and latest_version in state:modified
Aug 9, 2023
gshank
approved these changes
Aug 10, 2023
2 tasks
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8189
docs dbt-labs/docs.getdbt.com/# dbt-labs/docs.getdbt.com#3897
Problem
Solution
state:modified picks up changes to a model's ref representation:
access
deprecation_date
latest_version
Any of these may cause downstream
ref
calls to change: potential errors from changingaccess
, a different resolution of unpinned refs whenlatest_version
changes, or additional warnings fromdeprecation_date
.Checklist