Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --no-partial-parse-file-diff flag #8361

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Aug 11, 2023

resolves #8363
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Aug 11, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #8361 (6c8a708) into main (83ff38a) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8361      +/-   ##
==========================================
- Coverage   86.29%   86.24%   -0.05%     
==========================================
  Files         174      174              
  Lines       25529    25534       +5     
==========================================
- Hits        22030    22022       -8     
- Misses       3499     3512      +13     
Flag Coverage Δ
integration 83.00% <100.00%> (-0.12%) ⬇️
unit 65.17% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
core/dbt/cli/main.py 98.68% <100.00%> (+<0.01%) ⬆️
core/dbt/cli/params.py 100.00% <100.00%> (ø)
core/dbt/parser/manifest.py 90.20% <100.00%> (+0.03%) ⬆️

... and 3 files with indirect coverage changes

@MichelleArk MichelleArk marked this pull request as ready for review August 11, 2023 14:33
@MichelleArk MichelleArk requested a review from a team as a code owner August 11, 2023 14:33
@jtcohen6 jtcohen6 merged commit 8350dfe into main Aug 14, 2023
@jtcohen6 jtcohen6 deleted the no-partial-parse-file-diff branch August 14, 2023 11:24
github-actions bot pushed a commit that referenced this pull request Aug 14, 2023
* add --no-partial-parse-file-diff flag

* changelog entry

(cherry picked from commit 8350dfe)
jtcohen6 pushed a commit that referenced this pull request Aug 14, 2023
* add --no-partial-parse-file-diff flag

* changelog entry

(cherry picked from commit 8350dfe)

Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com>
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2961] Add flag to inform partial parsing to skip file diff computation
3 participants