-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add TestLargeEphemeralCompilation #8376
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #8376 +/- ##
==========================================
- Coverage 86.61% 86.56% -0.05%
==========================================
Files 175 175
Lines 25595 25595
==========================================
- Hits 22168 22156 -12
- Misses 3427 3439 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I checked out the commit (fecde23) prior to the fix: fdeccfa, but wasn't able to see this test fail. I copied the setup from https://github.com/jeremyyeo/ephemeral-invalid-sql-repro/tree/main/models, which is what I believe was used to produce the failed run here: https://github.com/jeremyyeo/ephemeral-invalid-sql-repro/actions/runs/5667308405/job/15355782134 But to my understanding, this issue is adapter-agnostic and should be reproducible in our functional tests that use postgres. |
Seeing the error in a failure when removing the fix introduced fdeccfa from CI logs running on ubuntu: https://github.com/dbt-labs/dbt-core/actions/runs/6165034837/job/16732021940?pr=8376 --- RunResultError
{"data": {"msg": "Database Error in test passing (tests/passing.sql)\n syntax error at or near \"with\"\n LINE 14: ) with my_other_cool_cte as (\n ^\n compiled Code at target/run/singular_tests_ephemeral/tests/passing.sql"}, "info": {"category": "", "code": "Z024", "extra": {}, "invocation_id": "d02541ec-e8e1-4dae-a7c8-de0373a37874", "level": "error", "msg": " Database Error in test passing (tests/passing.sql)\n syntax error at or near \"with\"\n LINE 14: ) with my_other_cool_cte as (\n ^\n compiled Code at target/run/singular_tests_ephemeral/tests/passing.sql", "name": "RunResultError", "pid": 4548, "thread": "MainThread", "ts": "2023-09-12T21:31:58.135065Z"}} |
(cherry picked from commit d597b80)
* Add new get_catalog_relations macro, allowing dbt to specify which relations in a schema the adapter should return data about * Implement postgres adapter support for relation filtering on catalog queries * Code review changes adding feature flag for catalog-by-relation-list support * Use profile specified in --profile with dbt init (#7450) * Use profile specified in --profile with dbt init * Update .changes/unreleased/Fixes-20230424-161642.yaml Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> * Refactor run() method into functions, replace exit() calls with exceptions * Update help text for profile option --------- Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> * add TestLargeEphemeralCompilation (#8376) * Fix a couple of issues in the postgres implementation of get_catalog_relations * Add relation count limit at which to fall back to batch retrieval * Better feature detection mechanism for adapters. * Code review changes to get_catalog_relations and adapter feature checking * Add changelog entry --------- Co-authored-by: ezraerb <ezraerb@alum.mit.edu> Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com>
* Add new get_catalog_relations macro, allowing dbt to specify which relations in a schema the adapter should return data about * Implement postgres adapter support for relation filtering on catalog queries * Code review changes adding feature flag for catalog-by-relation-list support * Use profile specified in --profile with dbt init (#7450) * Use profile specified in --profile with dbt init * Update .changes/unreleased/Fixes-20230424-161642.yaml Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> * Refactor run() method into functions, replace exit() calls with exceptions * Update help text for profile option --------- Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> * add TestLargeEphemeralCompilation (#8376) * Fix a couple of issues in the postgres implementation of get_catalog_relations * Add relation count limit at which to fall back to batch retrieval * Better feature detection mechanism for adapters. * Code review changes to get_catalog_relations and adapter feature checking * Add changelog entry --------- Co-authored-by: ezraerb <ezraerb@alum.mit.edu> Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com>
resolves #8225
docs dbt-labs/docs.getdbt.com/#
Problem
We are missing a test to capture a failure case for ephemeral model cte injection, which was resolved in #8215
Solution
Convert the reproduction case created here https://github.com/jeremyyeo/ephemeral-invalid-sql-repro/tree/main/models, which was used to produce the failed run here: https://github.com/jeremyyeo/ephemeral-invalid-sql-repro/actions/runs/5667308405/job/15355782134
Checklist